Skip to content

refactor(ui): remove styles already supplied by EMCN controls - #7979

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-redundant-control-styles
Sep 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-redundant-control-styles

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Product controls repeated classes already supplied by their active EMCN Button/Chip variants. Remove those redundant classes while preserving custom styling, variants, labels, handlers, and rendered content. For example, small ghost table-filter buttons retain the same vertical padding and text colour through EMCN instead of repeating py-1 and text-[var(--text-secondary)] locally.

This completes the reported redundant-style category: 66 occurrences at 50 control locations, resolved through 41 class-string edits across 25 product files. Shared constants account for several findings; all 10 consumers of the auth-button constant were checked to retain fullWidth, including the dynamic SSO wrapper. The branch follows merged PRs #7975 and #7977 and targets staging.

Validation:

  • Full external category scan: 66 redundant-style findings → 0. Missing-name and duplicate-artwork findings remain at 0. Coverage is unchanged, with no new analysis gaps.
  • Final committed-diff linter completed with no findings and zero introduced violations.
  • Before/after comparison using EMCN's actual class merger: identical final class sets at all 50 reported control locations across 67 resolved state combinations.
  • AST comparison: only the reviewed class-string removals and formatting changed; surrounding component syntax is unchanged.
  • 127 existing tests across 12 relevant suites pass. The resource suites were rerun after the final edit and all 18 tests pass.
  • App type check, repository-wide lint, API validation, and git diff --check pass.

All linter code, validation scripts, audit reports, and dependency installation remain outside the PR. Existing presentation exclusions and unrelated styling findings are unchanged in scope.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 18, 2026 7:53pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the removed utilities are supplied by the controls’ active EMCN base, variant, size, or full-width configuration.

Summary

This PR removes product-level utility classes that duplicate styling already supplied by active EMCN Button and Chip configurations.

  • Preserves authentication button width through the existing fullWidth prop.
  • Delegates padding, alignment, borders, radius, transitions, and standard colors to EMCN controls.
  • Retains control-specific dimensions, state colors, handlers, labels, and content.

Reviews (1) · Last reviewed commit: "refactor(ui): remove styles already supp..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 81cd643 into staging Sep 18, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-redundant-control-styles branch September 18, 2026 20:00

This branch was previously deployed

1 inactive deployment
Preview 9c239635 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants