Skip to content

fix(slack-search): reuse manifest installation in setup - #8013

Merged
TheodoreSpeaks merged 2 commits into
stagingfrom
codex/fix-slack-search-double-install
Sep 19, 2026
Merged

TheodoreSpeaks merged 2 commits into
stagingfrom
codex/fix-slack-search-double-install

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Connect the bot token from Slack's manifest installation instead of asking admins to install the custom app again.
  • Reuse the existing permission, ownership, and reconnect checks; refresh setup state before closing and update the Slack setup docs.

Type of Change

  • Bug fix

Testing

  • 164 focused tests passed across setup, authorization, callbacks, query refresh, and UI regressions.
  • App/auth type-checks, repository lint, all repository audits, API boundary validation, and docs checks passed. No migrations changed.
  • Live Slack installation was not completed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 19, 2026 6:07pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 16 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/knowledge/application/operations.ts
@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable correctness, security, or repository-rule failures remain.

Summary

This PR changes custom Slack Search setup to reuse the bot token produced by Slack’s manifest installation rather than initiating a second OAuth installation.

  • Adds a session-authenticated endpoint and authorized application operation for connecting an existing custom Slack bot.
  • Refactors installation persistence so manifest-token and OAuth completion paths share ownership, revision, concurrency, and workspace checks.
  • Refreshes installation, manifest, and organization-account queries before completing setup.
  • Updates the setup wizard, documentation, and focused regression coverage for the new flow.
Diagram
sequenceDiagram
  participant Admin
  participant Wizard
  participant API as Setup Connect API
  participant Slack
  participant DB
  participant Cache as Query Cache

  Admin->>Wizard: Paste installed xoxb bot token
  Wizard->>API: POST setup/connect
  API->>API: Authenticate session and authorize admin
  API->>Slack: Verify bot identity and required scopes
  Slack-->>API: App, workspace, bot, and scopes
  API->>DB: Lock app/workspace and validate ownership/revisions
  API->>DB: Encrypt and persist token and installation
  DB-->>API: Commit
  API-->>Wizard: Connected organization
  Wizard->>Cache: Refresh installation and setup queries
  Cache-->>Wizard: Updated installation state
  Wizard-->>Admin: Close completed setup
Loading

Reviews (2) · Last reviewed commit: "fix(slack-search): register token connec..."

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 17 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit be70351 into staging Sep 19, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-slack-search-double-install branch September 20, 2026 00:00

This branch was previously deployed

1 inactive deployment
Preview 1155a4d0 Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant