refactor(ui): reuse EMCN icons for simple product glyphs - #8016
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Contributor
Author
|
@greptileai please re-review the latest commit, fb2589f. The requested CircleStop usage example has been added and the thread resolved. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace locally drawn credential locks, plan-comparison checks, tag-navigation chevrons and the variables empty-state document with the existing EMCN icons. Move the distinct
CircleStopdrawing into EMCN, import it directly, and remove its product re-exports and obsolete mock.Caller sizes, colors, layout and interaction logic are preserved. The four reused icons intentionally adopt EMCN’s slightly different outlines; the stop icon keeps its exact drawing. Landing pages and specialized artwork are unchanged.
Validation: 343 EMCN tests and 534 existing message-content tests pass, along with all workspace type checks/lint, import resolution and API validation. The external audit confirms all five targeted artwork findings removed with zero new findings. A light/dark browser fixture verifies matching sizes and colors for all six examples (including both chevron sizes); full product browser interactions were not exercised. Review scripts and screenshots are outside this PR.