Skip to content

refactor(ui): reuse EMCN icons for simple product glyphs - #8016

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/control-fix-simple-icons
Sep 19, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/control-fix-simple-icons

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Replace locally drawn credential locks, plan-comparison checks, tag-navigation chevrons and the variables empty-state document with the existing EMCN icons. Move the distinct CircleStop drawing into EMCN, import it directly, and remove its product re-exports and obsolete mock.

Caller sizes, colors, layout and interaction logic are preserved. The four reused icons intentionally adopt EMCN’s slightly different outlines; the stop icon keeps its exact drawing. Landing pages and specialized artwork are unchanged.

Validation: 343 EMCN tests and 534 existing message-content tests pass, along with all workspace type checks/lint, import resolution and API validation. The external audit confirms all five targeted artwork findings removed with zero new findings. A light/dark browser fixture verifies matching sizes and colors for all six examples (including both chevron sizes); full product browser interactions were not exercised. Review scripts and screenshots are outside this PR.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
Image docs Ready Ready Preview Sep 19, 2026 6:50pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the requested documentation fix is complete and no outstanding findings remain.

Summary

The PR consolidates simple product glyphs into EMCN icons and moves the existing CircleStop drawing into the shared icon library.

  • Latest commit fb2589f872 adds the requested CircleStop usage example, including the public @sim/emcn/icons import and a sized invocation.
  • The previous documentation finding is fully fixed.
  • The latest commit changes documentation only; SVG rendering and runtime behavior are unchanged. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "docs(emcn): add CircleStop usage example"

Comment thread packages/emcn/src/icons/circle-stop.tsx

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai please re-review the latest commit, fb2589f. The requested CircleStop usage example has been added and the thread resolved.

@waleedlatif1
waleedlatif1 merged commit 5414fb9 into staging Sep 19, 2026
36 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-simple-icons branch September 19, 2026 18:55

This branch was successfully deployed

1 active deployment
Preview fb2589f8 Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants