Skip to content

refactor(ui): reuse EMCN chips for AI controls - #8020

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-wand-controls
Sep 19, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-wand-controls

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

The workflow editor used a separate generic Button for three AI wand triggers, the prompt bar’s close/send controls, and code copy. These six instances now use existing EMCN Chips; a small product-local WandButton shares the AI trigger treatment. The unused Button implementation/export is deleted, and its test mocks and import examples are updated.

The existing generation, visibility, pending/streaming, dismissal, and copy handlers are preserved. Controls adopt EMCN’s standard fill, shadow, icon color, hover, and disabled treatment. They become 30px tall instead of 32px, while width and 16px icons stay the same; copy corners become 8px and its scale effect is removed. No new design-system variants or landing changes.

Validation: 343 EMCN tests and 36 relevant consumer tests pass, along with all workspace type checks/lint, import resolution, API validation, and generated-rule sync. The external conformance audit removes all three targeted wand-shadow findings with zero added findings; no retired Button-path references remain. An isolated browser comparison covers light/dark enabled, disabled, copy, and actual prompt-bar ready/loading/streaming states, plus mouse/keyboard activation. Prompt-bar dimensions match. Live AI generation was not exercised. Audit and screenshot helpers are outside this PR.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
Image docs Ready Ready Preview Sep 19, 2026 7:07pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the migrated controls retain their native button semantics, accessibility labels, handlers, and state restrictions.

Summary

This PR consolidates six workflow-editor icon controls onto the existing EMCN Chip primitive and introduces a small shared WandButton wrapper.

  • Replaces code-copy and AI wand triggers while preserving handlers and state gates.
  • Replaces prompt-bar close and generation controls with accessible, labelled Chips.
  • Removes the now-unused application-local Button implementation and barrel exports.
  • Updates consumer mocks, adds prompt-bar interaction coverage, and documents the preferred EMCN import.

Reviews (1) · Last reviewed commit: "refactor(ui): reuse EMCN chips for AI co..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit c448b87 into staging Sep 19, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-wand-controls branch September 19, 2026 19:28

This branch was successfully deployed

1 active deployment
Preview a8d6e870 Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants