refactor(ui): reuse EMCN chips for AI controls - #8020
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow editor used a separate generic Button for three AI wand triggers, the prompt bar’s close/send controls, and code copy. These six instances now use existing EMCN Chips; a small product-local WandButton shares the AI trigger treatment. The unused Button implementation/export is deleted, and its test mocks and import examples are updated.
The existing generation, visibility, pending/streaming, dismissal, and copy handlers are preserved. Controls adopt EMCN’s standard fill, shadow, icon color, hover, and disabled treatment. They become 30px tall instead of 32px, while width and 16px icons stay the same; copy corners become 8px and its scale effect is removed. No new design-system variants or landing changes.
Validation: 343 EMCN tests and 36 relevant consumer tests pass, along with all workspace type checks/lint, import resolution, API validation, and generated-rule sync. The external conformance audit removes all three targeted wand-shadow findings with zero added findings; no retired Button-path references remain. An isolated browser comparison covers light/dark enabled, disabled, copy, and actual prompt-bar ready/loading/streaming states, plus mouse/keyboard activation. Prompt-bar dimensions match. Live AI generation was not exercised. Audit and screenshot helpers are outside this PR.