Skip to content

improvement(ui): share sidebar row action buttons - #8047

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-sidebar-row-actions
Sep 20, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-sidebar-row-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Share the compact sidebar action button across chat, workspace, workflow and folder rows. Preserve existing 18px geometry, caller-owned 14px/16px icons, refs and menu event handling.
  • Keep indicator and hover/touch visibility behavior in the existing row wrapper. Add the existing keyboard-only focus treatment to the action.

Type of Change

  • Improvement

Testing

  • All workspace type checks, lint, import/API validation and required repository audits pass.
  • 48 existing consumer tests pass. Source comparison confirms all five callers and the visibility wrapper preserve their logic.
  • Browser fixture checked in both themes and both icon sizes, including mouse and keyboard activation. Committed design check completed with zero findings; documented dynamic-analysis limitations remain.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 20, 2026 12:27am UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, accessibility, security, or repository-rule violations identified.

Summary

This PR extracts the repeated 18px sidebar action button into a shared SidebarRowAction component and migrates chat, workspace, workflow, and folder rows to use it.

  • Preserves each caller’s icon size, pointer and click handlers, menu positioning behavior, and surrounding visibility wrapper.
  • Adds the repository’s established keyboard-only focus-ring treatment.
  • Introduces no security-sensitive behavior or confirmed functional regression.

Reviews (1) · Last reviewed commit: "improvement(ui): share sidebar row actio..."

@waleedlatif1
waleedlatif1 merged commit 6e62541 into staging Sep 20, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-sidebar-row-actions branch September 20, 2026 00:55

This branch was previously deployed

1 inactive deployment
Preview ad51f945 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants