Skip to content

fix(ui): align remaining editor dropdown styling - #8051

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/align-editor-output-mcp-selectors
Sep 20, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/align-editor-output-mcp-selectors

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Align workflow Outputs and MCP operations access with the editor's existing Combobox styling. Editor controls intentionally retain this appearance until a coordinated migration.
  • Separate output-picker appearance from size so deployment forms explicitly retain chip styling.

Type of Change

  • Bug fix

Testing

  • 38 focused tests passed, covering output menus, public selectors, and MCP operation policies.
  • App type-check, repository lint, all 47 audits including API validation, and generated-artifact checks passed.
  • Verified light/dark before-and-after component previews, open menus, and MCP access-mode changes.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 20, 2026 1:26am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The component substitutions appear behaviorally compatible, but the PR should not merge until its use of legacy Combobox controls is reconciled with the repository’s explicit chip-family requirement.

Findings

  1. P2 Legacy control violates requirement

Summary

This PR separates output-selector size from visual style, explicitly preserves chip styling in deployment chat, and changes editor output and MCP policy selectors to the existing Combobox appearance.

  • Adds an explicit variant contract to OutputSelect.
  • Preserves chip chrome for the deployment output picker.
  • Updates focused tests for the new appearance contract.
  • Conflicts with the repository’s current requirement to prefer chip-family controls.

Reviews (1) · Last reviewed commit: "fix(ui): align remaining editor dropdown..."

Comment thread apps/sim/components/mcp/operation-policy-editor.tsx
@waleedlatif1
waleedlatif1 merged commit 04096b6 into staging Sep 20, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/align-editor-output-mcp-selectors branch September 20, 2026 01:30

This branch was previously deployed

1 inactive deployment
Preview 7b2c01f5 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant