Skip to content

feat(jev): add TypeSafe evaluation models to Agent - #8103

Merged
waleedlatif1 merged 14 commits into
stagingfrom
codex/jev-integration
Sep 22, 2026
Merged

waleedlatif1 merged 14 commits into
stagingfrom
codex/jev-integration

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add TypeSafe Jev as a native evaluation provider in the Agent model selector, using State and typed Choice, Score, and Noul questions.
  • Support hosted key rotation, normal model billing, and workspace/organization BYOK overrides. Default to jev-latest while retaining pinned and preview options.
  • Expose typed answer fields through the shared reference picker and preserve whole-object selection.
  • Reuse Agent permissions, secret projection, streaming, logs, and usage tracking. Include the official TypeSafe icon, brand color, bounded transport, retries, and documentation.

Type of Change

  • New feature

Testing

  • 3,441 tests passed across provider, credential, configuration, Agent, output-discovery, variable-resolution, and BYOK settings suites; five existing tests skipped.
  • Six authenticated live checks passed through the real provider and key resolver: all three Jev IDs through serialized workflow execution with hosted keys, streaming billing, stored-BYOK precedence and zero model charges, and invalid credentials. Database/auth infrastructure was mocked in this harness.
  • Five signed-in local browser workflow runs passed, including nested answers consumed by a downstream Function.
  • App, deployment-config, and setup type-checks; cleanup; lint; all 47 audits; block registry; and generated documentation checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 22, 2026 7:34pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable issue remains in the changes made since the previous review.

Summary

This PR adds TypeSafe Jev as a native Agent evaluation provider, including typed evaluation inputs and outputs, hosted and BYOK credential resolution, billing and usage integration, bounded provider transport, model registration, documentation, and regression coverage. Since the previous review, the provider credential subblocks were moved directly after the model selector so the API key appears before Jev’s State and Questions fields, with the corresponding test expectation updated.

  • Registers pinned, latest, and preview Jev models for Agent evaluation workflows.
  • Adds typed Choice, Score, and Noul question handling with structured answer discovery.
  • Integrates hosted key rotation, workspace and organization BYOK precedence, usage accounting, and provider branding.
  • Separates evaluation execution from conversational Agent settings and rejects evaluation models as chat fallbacks.
  • Adds provider, handler, output-discovery, credential, transport, and configuration tests.
Diagram
sequenceDiagram
  participant W as Workflow Agent
  participant H as Agent Handler
  participant K as Key Resolver
  participant T as TypeSafe Provider
  participant J as Jev API

  W->>H: model + state + typed questions
  H->>K: Resolve TypeSafe credential
  K-->>H: Workspace/org BYOK or hosted key
  H->>T: Native evaluation request
  T->>J: Bounded request with retries
  J-->>T: Typed answers and usage
  T-->>H: content + answers + tokens
  H-->>W: Structured Agent outputs
Loading

Reviews (14) · Last reviewed commit: "improvement(agent): place credentials be..."

Comment thread apps/sim/tools/jev/evaluate.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 25 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/tools/jev/choice.ts Outdated
Comment thread apps/sim/tools/jev/evaluate.ts Outdated
Comment thread apps/sim/tools/jev/shared.ts Outdated
Comment thread apps/sim/providers/typesafe/schema.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread apps/sim/blocks/blocks/jev.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 25 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/jev.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 25 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/jev.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 43 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

Comment thread apps/sim/lib/workflows/blocks/block-outputs.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 43 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 3e1e1fc into staging Sep 22, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/jev-integration branch September 22, 2026 19:37

This branch was previously deployed

1 inactive deployment
Preview b6c725e0 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant