Skip to content

fix(access-requests): clarify request navigation and empty states - #8125

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/access-requests-navigation
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/access-requests-navigation

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Move personal request history to the profile menu and give organization admins one Requests settings destination.
  • Preserve request history across plan and feature changes, and redirect saved Permission groups review links with their filters intact.
  • Show accurate empty, paused, and search states, workspace scope, and review counts using the existing request flows.

Type of Change

  • Bug fix

Testing

  • 428 focused tests passed; 9 optional integration tests skipped.
  • Full lint, all 47 repository audits including API boundary validation, and all-workspace type checks passed.
  • Verified role, deployment, paused-history, navigation, and legacy-link behavior in focused tests.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 22, 2026 4:17am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 33 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with request navigation, authorization, legacy-link migration, and filtered queue states remaining aligned.

Summary

This PR separates personal request history from administrative review, introduces a plan-independent Requests settings destination, migrates saved Permission groups review URLs, and improves request scope, count, paused, search, and empty-state messaging.

  • Moves “My access requests” into profile navigation.
  • Adds an organization-admin-only Requests settings section across workspace and organization surfaces.
  • Redirects legacy request-review tabs while preserving canonical request filters and selection.
  • Keeps request history and administration available independently of Permission groups entitlement.
  • Adds focused coverage for authorization, navigation, legacy links, deployment modes, counts, and empty states.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
    Profile[Profile menu] --> History[My access requests]
    History --> WorkspaceHistory[Workspace-scoped history]
    History --> OrganizationHistory[Organization-scoped history]

    OrgAdmin[Organization administrator] --> Requests[Settings → Requests]
    Requests --> Review[Review and manage request queue]

    Legacy[Permission groups URL<br/>access-view=requests] --> Gate[Authorize Requests section]
    Gate --> Canonical[Canonical Requests URL]
    Canonical --> Review
Loading

Reviews (1) · Last reviewed commit: "fix(access-requests): clarify request na..."

@waleedlatif1
waleedlatif1 merged commit 7c2213f into staging Sep 22, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/access-requests-navigation branch September 22, 2026 04:26

This branch was previously deployed

1 inactive deployment
Preview 2b4804c7 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant