Skip to content

fix(mcp): list servers without Credential Group access - #8143

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
codex/fix-mcp-server-list-credential-groups
Sep 22, 2026
Merged

TheodoreSpeaks merged 1 commit into
stagingfrom
codex/fix-mcp-server-list-credential-groups

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

The MCP Server dropdown failed with “An organization admin must allow this workspace to use Credential Groups” even when ordinary workspace MCP servers were available. The optional managed catalog now returns an empty result when Credential Groups are unavailable or the workspace has no allowed MCP connectors, so ordinary servers remain selectable.

The catalog evaluates the live organization policy before querying credential metadata and filters queries to permitted connectors. Managed credential execution retains its strict authorization checks. Availability lookup failures, missing or invalid policies, and other unexpected failures still propagate.

Type of Change

  • Bug fix

Testing

  • Reproduced the reported error with regression tests before applying the fix.
  • 82 tests passed across the MCP catalog, query hooks, managed execution, credential authorization, availability, workspace policy, and policy repository suites.
  • bun run check:api-validation and bun run check:api-validation:strict passed.
  • bun run check:application-graph passed.
  • bunx turbo run type-check --filter=@sim/app --filter=@sim/auth passed for both workspaces.
  • Biome checks on all changed files and git diff --check passed.

Release

Base: staging. Merging to staging triggers its deployment pipeline after CI gates. No merge, auto-merge, or deployment has been performed or authorized by this task. Production would require separate approval.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 22, 2026 5:34pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the optional catalog behavior is narrowly implemented without weakening managed credential execution or tenant scoping.

Summary

This PR makes the managed MCP catalog optional so unavailable Credential Groups do not prevent ordinary workspace MCP servers from being listed.

  • Returns an empty managed catalog when Credential Groups are unavailable, unconfigured, or grant no managed MCP connectors.
  • Evaluates the live organization resource policy and limits catalog queries to explicitly permitted connectors.
  • Preserves strict managed-credential execution authorization and propagates unexpected dependency or policy failures.
  • Adds regression coverage for ordinary-server listing, connector filtering, availability states, policy revocation, and error propagation.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[List MCP tool servers] --> B[List ordinary workspace servers]
  A --> C[Resolve managed MCP catalog]
  C --> D{Credential Groups available and configured?}
  D -- No --> E[Return empty managed catalog]
  D -- Yes --> F[Load live organization policy]
  F --> G[Determine permitted MCP connectors]
  G --> H{Any permitted connectors?}
  H -- No --> E
  H -- Yes --> I[Query managed credentials for permitted connectors]
  B --> J[Combine ordinary and managed servers]
  E --> J
  I --> J
Loading

Reviews (1) · Last reviewed commit: "fix(mcp): list servers without Credentia..."

@TheodoreSpeaks
TheodoreSpeaks merged commit 7de662e into staging Sep 22, 2026
34 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/fix-mcp-server-list-credential-groups branch September 22, 2026 17:44

This branch was previously deployed

1 inactive deployment
Preview f667da36 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant