Skip to content

refactor(ui): narrow local style forwarding and preview geometry - #8144

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-colour-assignment-followup
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-colour-assignment-followup

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Markdown cells and internal input/dropdown wrappers accept broader inline styles than their callers need. Restrict them to the properties actually used, and replace the PPTX preview wrappers’ interpolated CSS with explicit property assignments.

  • Preserve markdown left/center/right alignment while letting the existing classes own cell appearance.
  • Keep environment/reference dropdown positioning (top, left, zIndex) and discard unused secret-field inline styles.
  • Preserve both PPTX preview modes’ dimensions, background, clipping, margins and existing shadow.

No intended visual change. All 18 light/dark before-and-after fixture states matched in computed styling and geometry. All 18 before/after comparisons are attached here; they exercise the actual affected renderers/anchor code with local sample content, not authenticated end-to-end flows.

Validation: all 26 workspace type-check tasks, import-specifier check, API validation and changed-file lint pass; 63 relevant tests pass. Two existing chat timing assertions failed during the initial concurrent run and passed on the isolated rerun. The local design diff checker reports no new findings. Audit tooling and screenshots are outside the product diff.

GitHub CI passes, including the app build and PostgreSQL integration checks. Greptile and Cubic both report 5/5 on the current head.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 22, 2026 6:04pm UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before/after visual checks at 607b61368a0e4acef8af. Before is on the left; after is on the right. Each pair was captured together at the same zoom and viewport.

All 18 light/dark states matched in computed geometry, typography, colours, borders and shadows. These are isolated source fixtures, not authenticated end-to-end flows: real markdown renderers use the installed Streamdown pipeline; secret fields use the actual component; dropdown fixtures use the actual anchor JSX in EMCN popovers with sample rows; PPTX fixtures use the actual wrapper methods with sample slide content.

Markdown table alignment

light · aligned

Markdown table alignment — light aligned

dark · aligned

Markdown table alignment — dark aligned

Secret field masking and permission state

light · masked

Secret field masking and permission state — light masked

light · locked

Secret field masking and permission state — light locked

dark · masked

Secret field masking and permission state — dark masked

dark · locked

Secret field masking and permission state — dark locked

Environment-variable dropdown anchor

light · absolute

Environment-variable dropdown anchor — light absolute

light · fixed

Environment-variable dropdown anchor — light fixed

dark · absolute

Environment-variable dropdown anchor — dark absolute

dark · fixed

Environment-variable dropdown anchor — dark fixed

Workflow-reference dropdown anchor

light · absolute

Workflow-reference dropdown anchor — light absolute

light · fixed

Workflow-reference dropdown anchor — light fixed

dark · absolute

Workflow-reference dropdown anchor — dark absolute

dark · fixed

Workflow-reference dropdown anchor — dark fixed

PPTX preview wrappers

light · list

PPTX preview wrappers — light list

light · single

PPTX preview wrappers — light single

dark · list

PPTX preview wrappers — dark list

dark · single

PPTX preview wrappers — dark single

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable behavioral, security, or repository-rule violations identified.

Summary

This PR narrows inline-style forwarding to properties owned by each affected component while preserving existing dropdown placement, markdown alignment, secret-field layout, and PPTX preview geometry.

  • Restricts markdown table cells to forwarding alignment.
  • Restricts environment/reference dropdown positioning styles to top, left, and zIndex.
  • Removes unsupported inline styling from SecretValueField.
  • Replaces interpolated PPTX wrapper CSS with explicit style-property assignments.

Reviews (1) · Last reviewed commit: "refactor(ui): narrow local style forward..."

@waleedlatif1
waleedlatif1 merged commit 8e9d5fd into staging Sep 22, 2026
36 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-colour-assignment-followup branch September 22, 2026 18:39

This branch was previously deployed

1 inactive deployment
Preview 0e4acef8 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants