Skip to content

fix(access): align invitations and request navigation - #8145

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/invitation-access-ui
Sep 22, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/invitation-access-ui

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep My access requests inside the organization and workspace layouts, preserving navigation and existing deep links.
  • Compact invitations with workspace logos, access labels, and clear per-invitation actions.
  • Reuse standard query locations and simplify access request action chips.

Type of Change

  • Bug fix

Testing

  • 209 focused tests passed.
  • Full lint and type-check passed across all workspaces.
  • All 47 repository audits, block registry validation, and docs manifest check passed.
  • Checked single and multiple invitations, uploaded logos and fallback initials, request details, empty states, and scrolling in local previews.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
Image docs Skipped Skipped Sep 22, 2026 6:22pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 41 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/app/access-requests/page.tsx Outdated
Comment thread apps/sim/app/invite/components/invitation-disclosure.tsx
@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding correctness, security, or repository-rule failure was identified.

Summary

This PR aligns access-request navigation with organization and workspace layouts, consolidates access-request query hooks, and presents invitations with workspace identities and permission labels.

Changes since the previous review make the legacy requester route degrade to the authorized standalone view when optional organization-navigation context cannot be resolved, rather than failing the page.

  • Adds organization-shell routing for requester access links while preserving legacy deep links and query state.
  • Refactors invitation displays to associate workspace grants, logos, permissions, and actions clearly.
  • Moves access-request query hooks and key factories into the shared query hierarchy.
  • Preserves independent authorization at the access-request application boundary.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Legacy access-request link] --> B{Authenticated?}
  B -- No --> C[Login with callback]
  B -- Yes --> D{Admin review view?}
  D -- Yes --> E[Standalone admin review surface]
  D -- No --> F[Resolve organization navigation context]
  F -- Member-scoped search enabled --> G[Organization access-request route]
  F -- Unavailable, ineligible, or lookup failed --> H[Standalone requester surface]
  G --> I[Authorized access-request API]
  H --> I
Loading

Reviews (2) · Last reviewed commit: "fix(access): preserve standalone request..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 41 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 9d176cd into staging Sep 22, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/invitation-access-ui branch September 22, 2026 18:28

This branch was previously deployed

1 inactive deployment
Preview 55edd792 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant