Skip to content

Follow-up: Minor changes for creating standalone plugins #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 3 commits into from
Dec 19, 2023
Merged

Follow-up: Minor changes for creating standalone plugins #912

felixarntz merged 3 commits into from
Dec 19, 2023

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Dec 19, 2023

Summary

Follow-up to #652 and #880

This PR do following changes:

  • Remove duplicate admin notice call as it show notice on all admin pages.
  • Fix some minor PHP documentation.
  • Move inline script in to perflab-module-migration-notice.js file.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Dec 19, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Dec 19, 2023
@mukeshpanchal27 mukeshpanchal27 changed the title Follow-up: Minor changes for standalone plugins changes Follow-up: Minor changes for creating standalone plugins Dec 19, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review December 19, 2023 06:38
felixarntz
felixarntz approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, good catch!

@felixarntz felixarntz merged commit 30f1679 into feature/creating-standalone-plugins Dec 19, 2023
@felixarntz felixarntz deleted the fix/followup-changes branch December 19, 2023 15:39
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Dec 21, 2023
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

@felixarntz felixarntz felixarntz approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mukeshpanchal27 @swissspidy @felixarntz