Skip to content

fix!: test break by fn_{fn} -> {fn} breaking change#3123

Merged
tobegit3hub merged 2 commits into4paradigm:mainfrom
aceforeverd:fix-fz-fns
Mar 7, 2023
Merged

fix!: test break by fn_{fn} -> {fn} breaking change#3123
tobegit3hub merged 2 commits into4paradigm:mainfrom
aceforeverd:fix-fz-fns

Conversation

@aceforeverd
Copy link
Copy Markdown
Collaborator

@aceforeverd aceforeverd commented Mar 6, 2023

test break after #2818

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 6, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -5.78 ⚠️

Comparison is base (5530097) 81.48% compared to head (0bd0596) 75.71%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3123       +/-   ##
=============================================
- Coverage     81.48%   75.71%    -5.78%     
- Complexity        0      393      +393     
=============================================
  Files             8      672      +664     
  Lines           578   124862   +124284     
  Branches          0     1117     +1117     
=============================================
+ Hits            471    94541    +94070     
- Misses           91    30085    +29994     
- Partials         16      236      +220     
Impacted Files Coverage Δ
hybridse/src/vm/window_test.cc 99.31% <0.00%> (ø)
hybridse/include/node/expr_node.h 100.00% <0.00%> (ø)
hybridse/include/vm/engine.h 96.05% <0.00%> (ø)
hybridse/src/vm/jit_test.cc 97.18% <0.00%> (ø)
...paradigm/openmldb/batch/nodes/SelectIntoPlan.scala 52.38% <0.00%> (ø)
hybridse/include/base/fe_slice.h 97.43% <0.00%> (ø)
src/codec/sdk_codec.h 0.00% <0.00%> (ø)
src/cmd/sdk_iterator.h 0.00% <0.00%> (ø)
hybridse/src/vm/runner.cc 67.66% <0.00%> (ø)
src/storage/aggregator_test.cc 97.46% <0.00%> (ø)
... and 654 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2023

SDK Test Report

  92 files    92 suites   1m 38s ⏱️
185 tests 175 ✔️ 10 💤 0
231 runs  221 ✔️ 10 💤 0

Results for commit 0bd0596.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2023

HybridSE Linux Test Report

19 437 tests   19 435 ✔️  6m 52s ⏱️
     244 suites           2 💤
       67 files             0

Results for commit 0bd0596.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2023

HybridSE Mac Test Report

19 437 tests   19 435 ✔️  10m 46s ⏱️
     244 suites           2 💤
       67 files             0

Results for commit 0bd0596.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2023

Linux Test Report

       56 files       230 suites   1h 14m 55s ⏱️
11 923 tests 11 916 ✔️ 7 💤 0
16 924 runs  16 917 ✔️ 7 💤 0

Results for commit 0bd0596.

@aceforeverd aceforeverd changed the title fix: test break by fn_{fn} -> {fn} breaking change fix!: test break by fn_{fn} -> {fn} breaking change Mar 7, 2023
Copy link
Copy Markdown
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 03f7bcb into 4paradigm:main Mar 7, 2023
@aceforeverd aceforeverd deleted the fix-fz-fns branch March 7, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants