Skip to content

feat(udf doc gen): one udf doc fix and udf generate title #3141

Merged
aceforeverd merged 2 commits into4paradigm:mainfrom
aceforeverd:feat-engine-doc
Mar 15, 2023
Merged

feat(udf doc gen): one udf doc fix and udf generate title #3141
aceforeverd merged 2 commits into4paradigm:mainfrom
aceforeverd:feat-engine-doc

Conversation

@aceforeverd
Copy link
Copy Markdown
Collaborator

@aceforeverd aceforeverd commented Mar 13, 2023

There are two fixes:

  • fixes the doc example for join
  • fixes title of the generated udf markdown file

@aceforeverd aceforeverd marked this pull request as ready for review March 13, 2023 11:05
@github-actions github-actions bot added the execute-engine hybridse sql engine label Mar 13, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (3e7cbe5) 75.73% compared to head (628c05e) 75.72%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3141      +/-   ##
============================================
- Coverage     75.73%   75.72%   -0.02%     
  Complexity      393      393              
============================================
  Files           672      672              
  Lines        124836   124836              
  Branches       1117     1117              
============================================
- Hits          94546    94530      -16     
- Misses        30054    30070      +16     
  Partials        236      236              
Impacted Files Coverage Δ
hybridse/src/udf/default_defs/feature_zero_def.cc 83.38% <ø> (ø)

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2023

SDK Test Report

  92 files    92 suites   1m 38s ⏱️
185 tests 175 ✔️ 10 💤 0
231 runs  221 ✔️ 10 💤 0

Results for commit 628c05e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

HybridSE Linux Test Report

19 437 tests   19 435 ✔️  7m 26s ⏱️
     244 suites           2 💤
       67 files             0

Results for commit 628c05e.

@github-actions
Copy link
Copy Markdown
Contributor

HybridSE Mac Test Report

19 437 tests   19 435 ✔️  10m 4s ⏱️
     244 suites           2 💤
       67 files             0

Results for commit 628c05e.

@github-actions
Copy link
Copy Markdown
Contributor

Linux Test Report

       56 files       230 suites   1h 16m 18s ⏱️
11 923 tests 11 916 ✔️ 7 💤 0
16 924 runs  16 917 ✔️ 7 💤 0

Results for commit 628c05e.

Copy link
Copy Markdown
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit e5b7bf1 into 4paradigm:main Mar 15, 2023
@aceforeverd aceforeverd deleted the feat-engine-doc branch March 16, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-engine hybridse sql engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants