Skip to content

feat(sql): alter table .. add/drop offline_path#3286

Merged
aceforeverd merged 6 commits into4paradigm:mainfrom
aceforeverd:feat-alter-table-add-path
May 29, 2023
Merged

feat(sql): alter table .. add/drop offline_path#3286
aceforeverd merged 6 commits into4paradigm:mainfrom
aceforeverd:feat-alter-table-add-path

Conversation

@aceforeverd
Copy link
Copy Markdown
Collaborator

@aceforeverd aceforeverd commented May 18, 2023

Syntax

"ALTER" "TABLE" <table_path> [ "ADD" | "DROP" ] OFFLINE_PATH string_literal

@github-actions github-actions bot added build openmldb compiling and installing docker openmldb compile image or demo image execute-engine hybridse sql engine labels May 18, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 55.27% and project coverage change: -0.02 ⚠️

Comparison is base (8c9772f) 75.60% compared to head (ca2d960) 75.58%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3286      +/-   ##
============================================
- Coverage     75.60%   75.58%   -0.02%     
  Complexity      393      393              
============================================
  Files           681      681              
  Lines        125737   125696      -41     
  Branches       1185     1185              
============================================
- Hits          95058    95002      -56     
- Misses        30443    30458      +15     
  Partials        236      236              
Impacted Files Coverage Δ
hybridse/src/planv2/ast_node_converter_test.cc 95.59% <ø> (-0.01%) ⬇️
hybridse/src/planv2/planner_v2.cc 73.33% <ø> (ø)
hybridse/src/planv2/planner_v2.h 100.00% <ø> (ø)
hybridse/src/vm/physical_op.cc 79.47% <0.00%> (ø)
hybridse/src/node/sql_node.cc 76.60% <29.16%> (-1.59%) ⬇️
hybridse/src/planv2/ast_node_converter.cc 94.32% <90.32%> (-0.09%) ⬇️
hybridse/include/node/plan_node.h 96.03% <100.00%> (+0.05%) ⬆️
hybridse/include/node/sql_node.h 84.60% <100.00%> (+0.10%) ⬆️
hybridse/src/node/plan_node.cc 82.66% <100.00%> (+0.41%) ⬆️
hybridse/src/plan/planner.cc 88.14% <100.00%> (+0.08%) ⬆️
... and 1 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aceforeverd aceforeverd changed the title feat(sql): alter table .. add/drop path feat(sql): alter table .. add/drop offline_path May 24, 2023
@aceforeverd aceforeverd merged commit 0a2c617 into 4paradigm:main May 29, 2023
@aceforeverd aceforeverd deleted the feat-alter-table-add-path branch May 29, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build openmldb compiling and installing docker openmldb compile image or demo image execute-engine hybridse sql engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants