fix(#3023): query expr at(list, numeric) as non-window function#3298
Merged
aceforeverd merged 3 commits into4paradigm:mainfrom Jun 16, 2023
Merged
fix(#3023): query expr at(list, numeric) as non-window function#3298aceforeverd merged 3 commits into4paradigm:mainfrom
at(list, numeric) as non-window function#3298aceforeverd merged 3 commits into4paradigm:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3298 +/- ##
============================================
+ Coverage 75.58% 75.60% +0.01%
Complexity 393 393
============================================
Files 681 686 +5
Lines 125697 125852 +155
Branches 1186 1186
============================================
+ Hits 95014 95153 +139
- Misses 30446 30462 +16
Partials 237 237
☔ View full report in Codecov by Sentry. |
aceforeverd
changed the title
at(list, numric)at(list, numeric) as non-window function
vagetablechicken
approved these changes
Jun 1, 2023
lqy222
approved these changes
Jun 16, 2023
dl239
pushed a commit
that referenced
this pull request
Jun 29, 2023
) FIX support of `at` as non-window function, partially resolve #3023 distinct `at` & `lag`. Key difference: - `lag` & `lead` is window functions, and should only used with a window - `at` can be used else where too, like `at(split_by_key(col, ",", ":"), 1)`, a udf function The rules is not enforced in this PR, should be backward-compatible. So it may work like `lag(split(col, ','), 1)`, but is generally not recommended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX support of
atas non-window function.distinct
at&lag. Key difference:lag&leadis window functions, and should only used with a windowatcan be used else where too, likeat(split_by_key(col, ",", ":"), 1), a udf functionThe rules is not enforced in this PR, should be backward-compatible. So it may work like
lag(split(col, ','), 1), but is generally not recommended. Breaking changes may introduce later, see #3023 (comment).