Skip to content

feat(udf): top_n_value_ratio_cate & top_n_value_key_ratio_cate#3329

Merged
aceforeverd merged 10 commits into4paradigm:mainfrom
aceforeverd:feat-cate-ratio
Jun 28, 2023
Merged

feat(udf): top_n_value_ratio_cate & top_n_value_key_ratio_cate#3329
aceforeverd merged 10 commits into4paradigm:mainfrom
aceforeverd:feat-cate-ratio

Conversation

@aceforeverd
Copy link
Copy Markdown
Collaborator

@aceforeverd aceforeverd commented Jun 20, 2023

  • top_n_value_ratio_cate
  • top_n_key_ratio_cate
  • list_except_by_key
  • list_except_by_value

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jun 20, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 96.03% and project coverage change: +38.42 🎉

Comparison is base (82d1929) 37.27% compared to head (23d56bd) 75.70%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3329       +/-   ##
=============================================
+ Coverage     37.27%   75.70%   +38.42%     
  Complexity      414      414               
=============================================
  Files           177      692      +515     
  Lines         10238   125912   +115674     
  Branches       1189     1189               
=============================================
+ Hits           3816    95316    +91500     
- Misses         6181    30355    +24174     
  Partials        241      241               
Impacted Files Coverage Δ
...idse/src/udf/default_defs/count_by_category_def.cc 100.00% <ø> (ø)
...bridse/src/udf/default_defs/max_by_category_def.cc 100.00% <ø> (ø)
...bridse/src/udf/default_defs/min_by_category_def.cc 100.00% <ø> (ø)
...bridse/src/udf/default_defs/sum_by_category_def.cc 100.00% <ø> (ø)
...ridse/src/udf/default_defs/window_functions_def.cc 84.90% <ø> (ø)
hybridse/src/udf/containers.h 89.63% <85.00%> (ø)
hybridse/src/udf/default_defs/feature_zero_def.cc 84.35% <94.59%> (ø)
hybridse/src/udf/default_defs/aggregate_def.cc 100.00% <100.00%> (ø)
...bridse/src/udf/default_defs/avg_by_category_def.cc 100.00% <100.00%> (ø)
hybridse/src/udf/default_defs/containers.h 100.00% <100.00%> (ø)

... and 505 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aceforeverd aceforeverd marked this pull request as ready for review June 21, 2023 12:57
@aceforeverd aceforeverd changed the title feat(udf): top_n_value_ratio_cate_where & top_n_value_key_ratio_cate_where feat(udf): top_n_value_ratio_cate & top_n_value_key_ratio_cate Jun 26, 2023
@aceforeverd aceforeverd merged commit e060307 into 4paradigm:main Jun 28, 2023
@aceforeverd aceforeverd deleted the feat-cate-ratio branch June 28, 2023 06:34
dl239 pushed a commit that referenced this pull request Jun 29, 2023
- top_n_value_ratio_cate
- top_n_key_ratio_cate
- list_except_by_key
- list_except_by_value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-engine hybridse sql engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants