Skip to content

feat: support showing and dropping deployment with db#3353

Merged
dl239 merged 7 commits into4paradigm:mainfrom
emo-coder:feat/show_drop_deployment
Aug 7, 2023
Merged

feat: support showing and dropping deployment with db#3353
dl239 merged 7 commits into4paradigm:mainfrom
emo-coder:feat/show_drop_deployment

Conversation

@emo-coder
Copy link
Copy Markdown
Contributor

@emo-coder emo-coder commented Jul 10, 2023

close #3305

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jul 10, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: -0.02% ⚠️

Comparison is base (3a17aec) 75.73% compared to head (793d67c) 75.71%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3353      +/-   ##
============================================
- Coverage     75.73%   75.71%   -0.02%     
  Complexity      414      414              
============================================
  Files           703      703              
  Lines        127265   127271       +6     
  Branches       1206     1206              
============================================
- Hits          96379    96369      -10     
- Misses        30645    30661      +16     
  Partials        241      241              
Files Changed Coverage Δ
src/sdk/sql_cluster_router.cc 61.09% <85.71%> (+0.12%) ⬆️
hybridse/src/planv2/ast_node_converter.cc 94.38% <100.00%> (+0.01%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emo-coder emo-coder changed the title Feat/show drop deployment feat: show drop deployment Jul 11, 2023
@emo-coder emo-coder changed the title feat: show drop deployment feat: support showing and dropping deployment with db Jul 11, 2023
@emo-coder emo-coder marked this pull request as ready for review July 11, 2023 04:18
@dl239 dl239 merged commit d09d5e0 into 4paradigm:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop deployment command does not support specifying database

5 participants