feat: support inherit env variables for spark#3450
Merged
vagetablechicken merged 1 commit into4paradigm:mainfrom Aug 23, 2023
Merged
feat: support inherit env variables for spark#3450vagetablechicken merged 1 commit into4paradigm:mainfrom
vagetablechicken merged 1 commit into4paradigm:mainfrom
Conversation
github-actions
bot
added
documentation
...-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/config/TaskManagerConfig.java
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3450 +/- ##
============================================
+ Coverage 75.77% 75.80% +0.03%
Complexity 414 414
============================================
Files 703 703
Lines 127658 127658
Branches 1206 1200 -6
============================================
+ Hits 96729 96769 +40
+ Misses 30688 30648 -40
Partials 241 241
☔ View full report in Codecov by Sentry. |
vagetablechicken
requested review from
aceforeverd,
dl239,
lqy222 and
tobegit3hub
aceforeverd
approved these changes
Aug 21, 2023
| val env: java.util.Map[String, String] = new java.util.HashMap[String, String] | ||
| // config may empty, need check | ||
| if (!TaskManagerConfig.isEmpty(TaskManagerConfig.HADOOP_CONF_DIR)) { | ||
| env.put("HADOOP_CONF_DIR", TaskManagerConfig.HADOOP_CONF_DIR) |
Collaborator
Author
There was a problem hiding this comment.
test taskmanager conf file > system env
Collaborator
Author
There was a problem hiding this comment.
Test on new taskmanager, check by classpath print of zk in log file: if conf file, HADOOP_CONF_DIR in conf file is in the print, if no conf file, use the system env.
But the system env is passed by taskmanager too. So I test one more case:
- set HADOOP_CONF_DIR in user scope, dir1
- start taskmanager with conf option, dir2, pass to sparklauncher
- change env HADOOP_CONF_DIR (no effect) dir3
- submit spark job, use which env?
result: use the taskmanager conf
lqy222
approved these changes
Aug 23, 2023
dl239
pushed a commit
that referenced
this pull request
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3448