fix(#3491): support window union multiple join in request mode#3493
Merged
aceforeverd merged 1 commit into4paradigm:mainfrom Sep 25, 2023
Merged
fix(#3491): support window union multiple join in request mode#3493aceforeverd merged 1 commit into4paradigm:mainfrom
aceforeverd merged 1 commit into4paradigm:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3493 +/- ##
=============================================
+ Coverage 37.14% 75.37% +38.22%
Complexity 414 414
=============================================
Files 179 707 +528
Lines 10364 128663 +118299
Branches 1191 1191
=============================================
+ Hits 3850 96976 +93126
- Misses 6273 31446 +25173
Partials 241 241
☔ View full report in Codecov by Sentry. |
lqy222
approved these changes
Sep 25, 2023
vagetablechicken
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always construct new physical nodes in a optimizer. The optimizer has a physical node cache builtin that prevent updating existing physical node in place.
When a physical node hit cache with the same node id, will break the optimize step afterwards: reconstructing schema context, which cause the issue in #3491
Ref
OpenMLDB/hybridse/src/passes/physical/group_and_sort_optimized.cc
Lines 440 to 448 in 0fa0fe9