Skip to content

feat: check table status when CLI login#3506

Merged
aceforeverd merged 2 commits into4paradigm:mainfrom
vagetablechicken:3505-cli-check-all-table-status-when-login
Oct 11, 2023
Merged

feat: check table status when CLI login#3506
aceforeverd merged 2 commits into4paradigm:mainfrom
vagetablechicken:3505-cli-check-all-table-status-when-login

Conversation

@vagetablechicken
Copy link
Copy Markdown
Collaborator

@vagetablechicken vagetablechicken commented Sep 13, 2023

closes #3505
print unhealthy table msg and give a hint to console

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Sep 13, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 2.94% and project coverage change: +38.16% 🎉

Comparison is base (a013ba3) 37.14% compared to head (7102e0a) 75.31%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3506       +/-   ##
=============================================
+ Coverage     37.14%   75.31%   +38.16%     
- Complexity      414      587      +173     
=============================================
  Files           179      716      +537     
  Lines         10364   129613   +119249     
  Branches       1191     1280       +89     
=============================================
+ Hits           3850    97612    +93762     
- Misses         6273    31715    +25442     
- Partials        241      286       +45     
Files Changed Coverage Δ
src/sdk/sql_cluster_router.cc 60.53% <0.00%> (ø)
src/cmd/sql_cmd.h 21.89% <3.03%> (ø)

... and 561 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagetablechicken vagetablechicken marked this pull request as ready for review September 19, 2023 02:28
Copy link
Copy Markdown
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 1386632 into 4paradigm:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI check all table status when login

3 participants