Skip to content

refactor(codegen): null safe for struct ir builder #3547

Merged
aceforeverd merged 1 commit into4paradigm:mainfrom
aceforeverd:refactor-codegen-null-safety
Oct 26, 2023
Merged

refactor(codegen): null safe for struct ir builder #3547
aceforeverd merged 1 commit into4paradigm:mainfrom
aceforeverd:refactor-codegen-null-safety

Conversation

@aceforeverd
Copy link
Copy Markdown
Collaborator

fixes #926

@github-actions github-actions bot added the execute-engine hybridse sql engine label Oct 11, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (6fe2a30) 39.13% compared to head (0583dff) 75.31%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3547       +/-   ##
=============================================
+ Coverage     39.13%   75.31%   +36.18%     
  Complexity      587      587               
=============================================
  Files           188      718      +530     
  Lines         11093   129779   +118686     
  Branches       1280     1280               
=============================================
+ Hits           4341    97745    +93404     
- Misses         6466    31748    +25282     
  Partials        286      286               
Files Coverage Δ
hybridse/src/codegen/date_ir_builder.cc 67.46% <ø> (ø)
hybridse/src/codegen/expr_ir_builder.cc 79.97% <100.00%> (ø)
hybridse/src/codegen/native_value.h 100.00% <ø> (ø)
hybridse/src/codegen/string_ir_builder.cc 84.57% <ø> (ø)
hybridse/src/codegen/timestamp_ir_builder.cc 70.81% <100.00%> (ø)
hybridse/src/codegen/type_ir_builder.h 100.00% <ø> (ø)
hybridse/src/udf/default_udf_library.cc 97.25% <100.00%> (ø)
hybridse/src/codegen/array_ir_builder.h 25.00% <0.00%> (ø)
hybridse/src/codegen/ir_base_builder.cc 67.98% <66.66%> (ø)
hybridse/src/codegen/type_ir_builder.cc 82.05% <85.00%> (ø)
... and 3 more

... and 517 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd force-pushed the refactor-codegen-null-safety branch from 90b5d5a to 0583dff Compare October 23, 2023 14:42
Copy link
Copy Markdown
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 671897e into 4paradigm:main Oct 26, 2023
@aceforeverd aceforeverd deleted the refactor-codegen-null-safety branch October 26, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-engine hybridse sql engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codegen: NativeValue represent const null safely

3 participants