Skip to content

feat: catch error msgs in ns/tablet client#3587

Merged
dl239 merged 7 commits into4paradigm:mainfrom
vagetablechicken:3562-tablet-client-loadtable-should-show-error-msg
Nov 16, 2023
Merged

feat: catch error msgs in ns/tablet client#3587
dl239 merged 7 commits into4paradigm:mainfrom
vagetablechicken:3562-tablet-client-loadtable-should-show-error-msg

Conversation

@vagetablechicken
Copy link
Copy Markdown
Collaborator

closes #3562

@github-actions github-actions bot added documentation Improvements or additions to documentation workflow CICD related storage-engine openmldb storage engine. nameserver & tablet labels Nov 10, 2023
@vagetablechicken vagetablechicken force-pushed the 3562-tablet-client-loadtable-should-show-error-msg branch from 129494e to 4ca8cfa Compare November 10, 2023 07:18
@github-actions github-actions bot removed the workflow CICD related label Nov 10, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (825d155) 75.33% compared to head (55796e2) 75.37%.

Files Patch % Lines
src/client/ns_client.cc 0.00% 34 Missing ⚠️
src/client/tablet_client.cc 78.78% 7 Missing ⚠️
src/sdk/sql_cluster_router.cc 66.66% 3 Missing ⚠️
src/datacollector/data_collector.cc 0.00% 2 Missing ⚠️
src/base/status.h 0.00% 1 Missing ⚠️
src/tablet/tablet_impl.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3587      +/-   ##
============================================
+ Coverage     75.33%   75.37%   +0.04%     
  Complexity      635      635              
============================================
  Files           727      727              
  Lines        130673   130659      -14     
  Branches       1317     1317              
============================================
+ Hits          98446    98490      +44     
+ Misses        31936    31878      -58     
  Partials        291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 merged commit 84a1ffc into 4paradigm:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tablet client LoadTable should show error msg

3 participants