Skip to content

fix: fix taskmanager config handle null string#3597

Merged
dl239 merged 2 commits into4paradigm:mainfrom
tobegit3hub:fix/fix_taskmanager_config_handle_null_string
Nov 16, 2023
Merged

fix: fix taskmanager config handle null string#3597
dl239 merged 2 commits into4paradigm:mainfrom
tobegit3hub:fix/fix_taskmanager_config_handle_null_string

Conversation

@tobegit3hub
Copy link
Copy Markdown
Collaborator

@tobegit3hub tobegit3hub self-assigned this Nov 15, 2023
@github-actions github-actions bot added the task-manager openmldb taskmanager label Nov 15, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (825d155) 75.33% compared to head (e311d0a) 75.33%.

Files Patch % Lines
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3597      +/-   ##
============================================
- Coverage     75.33%   75.33%   -0.01%     
  Complexity      635      635              
============================================
  Files           727      727              
  Lines        130673   130673              
  Branches       1317     1317              
============================================
- Hits          98446    98443       -3     
- Misses        31936    31939       +3     
  Partials        291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobegit3hub
Copy link
Copy Markdown
Collaborator Author

# Server Config
server.host=0.0.0.0
server.port=9902
server.worker_threads=4
server.io_threads=4
server.channel_keep_alive_time=1800
prefetch.jobid.num=1
job.log.path=./logs/
external.function.dir=./udf/
track.unfinished.jobs=true
job.tracker.interval=30

# OpenMLDB Config
zookeeper.cluster=0.0.0.0:2181
zookeeper.root_path=/openmldb
zookeeper.session_timeout=5000
zookeeper.connection_timeout=5000
zookeeper.max_retries=10
zookeeper.base_sleep_time=1000
zookeeper.max_connect_waitTime=30000

# Spark Config
spark.master=local[*]
offline.data.prefix=file:///tmp/openmldb_offline_storage/

@dl239 dl239 merged commit d4f7c82 into 4paradigm:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task-manager openmldb taskmanager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to start taskmanager server when not configuring hadoop.conf.dir

3 participants