Skip to content

feat(offline): support & test new SQLs from online mode#3619

Merged
vagetablechicken merged 2 commits into4paradigm:mainfrom
aceforeverd:feat-offline-left-join
Dec 7, 2023
Merged

feat(offline): support & test new SQLs from online mode#3619
vagetablechicken merged 2 commits into4paradigm:mainfrom
aceforeverd:feat-offline-left-join

Conversation

@aceforeverd
Copy link
Copy Markdown
Collaborator

@aceforeverd aceforeverd commented Nov 22, 2023

  • fix WINDOW without ORDER BY in batch mode
  • support WINDOW without ORDER BY offline, only work if SkewWindowOpt is off
  • support last join (window/last join) offline

Ref #3615

@github-actions github-actions bot added batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine labels Nov 22, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4433970) 74.98% compared to head (6f7dac3) 74.99%.
Report is 5 commits behind head on main.

Files Patch % Lines
...radigm/openmldb/batch/utils/PhysicalNodeUtil.scala 57.14% 3 Missing ⚠️
hybridse/src/vm/core_api.cc 0.00% 2 Missing ⚠️
hybridse/src/vm/mem_catalog.cc 98.63% 1 Missing ⚠️
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 50.00% 1 Missing ⚠️
...digm/openmldb/batch/window/WindowAggPlanUtil.scala 85.71% 1 Missing ⚠️
...aradigm/openmldb/batch/window/WindowComputer.scala 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3619   +/-   ##
=========================================
  Coverage     74.98%   74.99%           
  Complexity      640      640           
=========================================
  Files           724      724           
  Lines        130359   130383   +24     
  Branches       1318     1310    -8     
=========================================
+ Hits          97746    97775   +29     
+ Misses        32320    32315    -5     
  Partials        293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd changed the title feat(offline): WINDOW without ORDER BY feat(offline): window without order by Nov 23, 2023
only work if SkewWindowOpt is off
@aceforeverd aceforeverd force-pushed the feat-offline-left-join branch from f50c1a1 to ae859d4 Compare November 23, 2023 08:24
@aceforeverd aceforeverd changed the title feat(offline): window without order by feat(offline): support & test new SQLs from online mode Nov 24, 2023
Copy link
Copy Markdown
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken merged commit 2eb802c into 4paradigm:main Dec 7, 2023
@aceforeverd aceforeverd deleted the feat-offline-left-join branch December 7, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants