Skip to content

feat: delete dirty data when insert fails#3681

Merged
dl239 merged 5 commits into4paradigm:mainfrom
dl239:feat/insert_failed
Jan 16, 2024
Merged

feat: delete dirty data when insert fails#3681
dl239 merged 5 commits into4paradigm:mainfrom
dl239:feat/insert_failed

Conversation

@dl239
Copy link
Copy Markdown
Collaborator

@dl239 dl239 commented Dec 22, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Dec 22, 2023
@dl239 dl239 changed the title feat: revert if put failed feat: delete partially inserted data if insert failed Dec 22, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (a112872) 78.27% compared to head (04ce1f7) 74.90%.

Files Patch % Lines
src/sdk/sql_cluster_router.cc 2.04% 48 Missing ⚠️
src/sdk/sql_insert_row.cc 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3681      +/-   ##
============================================
- Coverage     78.27%   74.90%   -3.38%     
- Complexity        0      654     +654     
============================================
  Files           553      729     +176     
  Lines        120481   131138   +10657     
  Branches          0     1341    +1341     
============================================
+ Hits          94312    98233    +3921     
- Misses        26153    32606    +6453     
- Partials         16      299     +283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 marked this pull request as ready for review December 25, 2023 07:59
@dl239 dl239 changed the title feat: delete partially inserted data if insert failed feat: delete dirty data when insert fails Dec 25, 2023
@dl239 dl239 linked an issue Dec 25, 2023 that may be closed by this pull request
@dl239 dl239 merged commit 4188240 into 4paradigm:main Jan 16, 2024
@dl239 dl239 deleted the feat/insert_failed branch January 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

delete data if insert statement execute failed

3 participants