feat: offline with git submodule#3787
Merged
aceforeverd merged 16 commits into4paradigm:mainfrom Mar 4, 2024
Merged
Conversation
modified: docker/Dockerfile_offline
Collaborator
|
requires #3778 |
Contributor
SDK Test Report101 files ±0 101 suites ±0 2m 4s ⏱️ -4s Results for commit a8413c8. ± Comparison against base commit c2e77b2. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
aceforeverd
reviewed
Feb 28, 2024
dl239
reviewed
Feb 28, 2024
dl239
reviewed
Feb 28, 2024
dl239
reviewed
Feb 28, 2024
aceforeverd
reviewed
Mar 1, 2024
aceforeverd
reviewed
Mar 1, 2024
aceforeverd
reviewed
Mar 1, 2024
aceforeverd
reviewed
Mar 1, 2024
aceforeverd
reviewed
Mar 1, 2024
aceforeverd
reviewed
Mar 1, 2024
aceforeverd
reviewed
Mar 1, 2024
tobegit3hub
reviewed
Mar 1, 2024
tobegit3hub
reviewed
Mar 1, 2024
aceforeverd
reviewed
Mar 1, 2024
aceforeverd
requested changes
Mar 1, 2024
Collaborator
|
@QiChenX pls ensure all CIs pass |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3787 +/- ##
============================================
+ Coverage 74.93% 74.95% +0.01%
Complexity 658 658
============================================
Files 738 739 +1
Lines 133155 133157 +2
Branches 1380 1380
============================================
+ Hits 99782 99805 +23
+ Misses 33069 33048 -21
Partials 304 304 ☔ View full report in Codecov by Sentry. |
aceforeverd
reviewed
Mar 1, 2024
aceforeverd
approved these changes
Mar 4, 2024
dl239
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
docker image for developers to build openmldb from scratch without internet for native codes #3760
manage rapidjson directly using git submodule
What is the new behavior (if this is a feature change)?
bundle rapidjson & farmhash directly in source code, allowing users to compile OpenMLDB offline