feat(map): cast null or map() to explicit map type#3847
Merged
aceforeverd merged 1 commit into4paradigm:mainfrom Apr 17, 2024
Merged
feat(map): cast null or map() to explicit map type#3847aceforeverd merged 1 commit into4paradigm:mainfrom
aceforeverd merged 1 commit into4paradigm:mainfrom
Conversation
Contributor
SDK Test Report101 files ±0 101 suites ±0 2m 13s ⏱️ ±0s Results for commit 38978b9. ± Comparison against base commit 7f758af. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
Linux Test Report 57 files 244 suites 1h 39m 51s ⏱️ Results for commit 38978b9. ♻️ This comment has been updated with latest results. |
Contributor
Contributor
2991987 to
c14fa9f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3847 +/- ##
============================================
+ Coverage 74.87% 74.88% +0.01%
Complexity 658 658
============================================
Files 742 742
Lines 133925 134056 +131
Branches 1387 1387
============================================
+ Hits 100277 100391 +114
- Misses 33344 33361 +17
Partials 304 304 ☔ View full report in Codecov by Sentry. |
Auto casting to target type when necessary, which usually happens with insert statement while a default schema defined by target table. This supports constructing null or empty values from offline engine.
c14fa9f to
38978b9
Compare
vagetablechicken
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements to new insert row builder:
Auto casting to target type when necessary, which usually happens with insert statement while a default schema defined by target table.
With the patch (whenever
InsertRowBuilderused), it canNULLplace holder, so insert statement likeinsert to t1 values (1, null, null, map())simply work for table t1(int, timestamp, map<int, string>, map<timestamp, int>)