Update properties sent to client#4258
Merged
LtRipley36706 merged 7 commits intoACEmulator:masterfrom Jan 15, 2025
Merged
Conversation
gmriggs
reviewed
Dec 24, 2024
gmriggs
reviewed
Dec 24, 2024
gmriggs
reviewed
Dec 24, 2024
gmriggs
reviewed
Dec 24, 2024
gmriggs
reviewed
Dec 24, 2024
gmriggs
reviewed
Dec 24, 2024
gmriggs
reviewed
Dec 24, 2024
gmriggs
previously approved these changes
Dec 24, 2024
gmriggs
previously approved these changes
Dec 24, 2024
LtRipley36706
previously approved these changes
Dec 29, 2024
rkroska
reviewed
Dec 31, 2024
gmriggs
approved these changes
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the properties sent to the client on login and appraisal. Based on PCaps and client information, an adjustment of these properties has been done to ensure ACE is not sending more information than the client needs. Fixes some potential exploits in addition to wasted bandwidth.
Removed some unused property attributes and functions while it was being cleaned up. All properties are now what formerly were tagged
[ServerOnly]unless they have the[SendOnLogin]or[AssessmentProperty].Note that many properties are no longer tagged with the AssessmentProperty attribute because they are, and always have been, sent elsewhere (e.g. in the CreateObject message or in Armor or Weapon profile part of the AppraiseInfo message)
This will undoubtedly "break" some post-retail plugins/tools that were using some of this extended data, but the client should never have had this data to begin with.