Add missing OnTalk to a few places#4301
Merged
LtRipley36706 merged 1 commit intoACEmulator:masterfrom Apr 6, 2025
Merged
Conversation
OnTalk was missing from Suicide and DoSpellWords, both of which used GameMessageHearSpeech OnTalk is currently a player function, it is possible it should be moved up the chain so the two remaining GameMessageHearSpeech and similar messages for Creatures or WorldObjects should be included in making HearChat emotes be triggered by players and npc alike for custom content purposes, but there may be a hidden problem with expanding that scope, so I'm not doing that for now.
gmriggs
approved these changes
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnTalk was missing from Suicide and DoSpellWords, both of which used GameMessageHearSpeech
OnTalk is currently a player function, it is possible it should be moved up the chain so the two remaining GameMessageHearSpeech and similar messages for Creatures or WorldObjects should be included in making HearChat emotes be triggered by players and npc alike for custom content purposes, but there may be a hidden problem with expanding that scope, so I'm not doing that for now.