deprecating legacy loot system#4314
Merged
LtRipley36706 merged 1 commit intoACEmulator:masterfrom May 11, 2025
Merged
Conversation
LtRipley36706
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize for reordering some of the functions. I realize that it makes reviewing the diff for this already large PR even more difficult.
This fully deprecates the legacy loot system, and removes the last remnants of the code for it.
I'm not aware of anyone still using the legacy loot system since the most recent version went live almost 5 years ago, but if anyone does still need it, it will always be available in the git history for the project.
We've had numerous instances of people being confused by the old code still in the project, and mistaking the old code for the most recent version. This will hopefully clear up a lot of that confusion, and make the code much simpler to read.
Tested through static analysis, the /testlootgen command, and manual playtesting