Fix Capture Expressions support for multi-probes#10519
Fix Capture Expressions support for multi-probes#10519gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (321.079 µs) : 287, 355
. : milestone, 321,
basic (279.628 µs) : 273, 287
. : milestone, 280,
loop (8.961 ms) : 8956, 8965
. : milestone, 8961,
section candidate
noprobe (332.866 µs) : 271, 395
. : milestone, 333,
basic (278.05 µs) : 271, 285
. : milestone, 278,
loop (8.963 ms) : 8959, 8966
. : milestone, 8963,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~617b47a8ad, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065049
Total [baseline] (8.747 s) : 0, 8746929
Agent [candidate] (1.07 s) : 0, 1070052
Total [candidate] (8.768 s) : 0, 8767582
section iast
Agent [baseline] (1.231 s) : 0, 1231344
Total [baseline] (9.373 s) : 0, 9373205
Agent [candidate] (1.231 s) : 0, 1231373
Total [candidate] (9.369 s) : 0, 9368823
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~617b47a8ad, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (628.251 ms) : 0, 628251
BytebuddyAgent [candidate] (631.757 ms) : 0, 631757
AgentMeter [baseline] (28.868 ms) : 0, 28868
AgentMeter [candidate] (28.949 ms) : 0, 28949
GlobalTracer [baseline] (257.716 ms) : 0, 257716
GlobalTracer [candidate] (259.053 ms) : 0, 259053
AppSec [baseline] (32.825 ms) : 0, 32825
AppSec [candidate] (33.108 ms) : 0, 33108
Debugger [baseline] (59.459 ms) : 0, 59459
Debugger [candidate] (60.593 ms) : 0, 60593
Remote Config [baseline] (623.963 µs) : 0, 624
Remote Config [candidate] (638.522 µs) : 0, 639
Telemetry [baseline] (15.312 ms) : 0, 15312
Telemetry [candidate] (13.223 ms) : 0, 13223
Flare Poller [baseline] (5.386 ms) : 0, 5386
Flare Poller [candidate] (6.098 ms) : 0, 6098
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (795.957 ms) : 0, 795957
BytebuddyAgent [candidate] (796.483 ms) : 0, 796483
AgentMeter [baseline] (11.27 ms) : 0, 11270
AgentMeter [candidate] (11.255 ms) : 0, 11255
GlobalTracer [baseline] (247.878 ms) : 0, 247878
GlobalTracer [candidate] (248.055 ms) : 0, 248055
AppSec [baseline] (33.184 ms) : 0, 33184
AppSec [candidate] (35.494 ms) : 0, 35494
Debugger [baseline] (66.681 ms) : 0, 66681
Debugger [candidate] (63.839 ms) : 0, 63839
Remote Config [baseline] (543.151 µs) : 0, 543
Remote Config [candidate] (553.368 µs) : 0, 553
Telemetry [baseline] (8.741 ms) : 0, 8741
Telemetry [candidate] (8.716 ms) : 0, 8716
Flare Poller [baseline] (3.496 ms) : 0, 3496
Flare Poller [candidate] (3.505 ms) : 0, 3505
IAST [baseline] (27.047 ms) : 0, 27047
IAST [candidate] (27.11 ms) : 0, 27110
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~617b47a8ad, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064215
Total [baseline] (10.774 s) : 0, 10773574
Agent [candidate] (1.07 s) : 0, 1070185
Total [candidate] (10.979 s) : 0, 10978669
section appsec
Agent [baseline] (1.24 s) : 0, 1239719
Total [baseline] (11.006 s) : 0, 11006283
Agent [candidate] (1.237 s) : 0, 1236832
Total [candidate] (10.981 s) : 0, 10980944
section iast
Agent [baseline] (1.232 s) : 0, 1232003
Total [baseline] (11.25 s) : 0, 11249724
Agent [candidate] (1.231 s) : 0, 1231080
Total [candidate] (11.23 s) : 0, 11230148
section profiling
Agent [baseline] (1.191 s) : 0, 1191137
Total [baseline] (10.95 s) : 0, 10950407
Agent [candidate] (1.216 s) : 0, 1215666
Total [candidate] (11.148 s) : 0, 11148003
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~617b47a8ad, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (628.632 ms) : 0, 628632
BytebuddyAgent [candidate] (630.859 ms) : 0, 630859
AgentMeter [baseline] (28.861 ms) : 0, 28861
AgentMeter [candidate] (29.139 ms) : 0, 29139
GlobalTracer [baseline] (257.705 ms) : 0, 257705
GlobalTracer [candidate] (259.007 ms) : 0, 259007
AppSec [baseline] (32.805 ms) : 0, 32805
AppSec [candidate] (33.035 ms) : 0, 33035
Debugger [baseline] (60.552 ms) : 0, 60552
Debugger [candidate] (63.279 ms) : 0, 63279
Remote Config [baseline] (625.619 µs) : 0, 626
Remote Config [candidate] (615.287 µs) : 0, 615
Telemetry [baseline] (14.0 ms) : 0, 14000
Telemetry [candidate] (9.931 ms) : 0, 9931
Flare Poller [baseline] (4.585 ms) : 0, 4585
Flare Poller [candidate] (7.651 ms) : 0, 7651
section appsec
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (658.749 ms) : 0, 658749
BytebuddyAgent [candidate] (656.451 ms) : 0, 656451
AgentMeter [baseline] (11.9 ms) : 0, 11900
AgentMeter [candidate] (11.858 ms) : 0, 11858
GlobalTracer [baseline] (258.892 ms) : 0, 258892
GlobalTracer [candidate] (258.45 ms) : 0, 258450
AppSec [baseline] (167.721 ms) : 0, 167721
AppSec [candidate] (167.637 ms) : 0, 167637
Debugger [baseline] (67.449 ms) : 0, 67449
Debugger [candidate] (67.374 ms) : 0, 67374
Remote Config [baseline] (667.47 µs) : 0, 667
Remote Config [candidate] (657.596 µs) : 0, 658
Telemetry [baseline] (9.186 ms) : 0, 9186
Telemetry [candidate] (9.187 ms) : 0, 9187
Flare Poller [baseline] (3.595 ms) : 0, 3595
Flare Poller [candidate] (3.677 ms) : 0, 3677
IAST [baseline] (25.143 ms) : 0, 25143
IAST [candidate] (25.185 ms) : 0, 25185
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (796.303 ms) : 0, 796303
BytebuddyAgent [candidate] (795.387 ms) : 0, 795387
AgentMeter [baseline] (11.249 ms) : 0, 11249
AgentMeter [candidate] (11.278 ms) : 0, 11278
GlobalTracer [baseline] (247.93 ms) : 0, 247930
GlobalTracer [candidate] (248.011 ms) : 0, 248011
AppSec [baseline] (31.416 ms) : 0, 31416
AppSec [candidate] (33.953 ms) : 0, 33953
Debugger [baseline] (68.917 ms) : 0, 68917
Debugger [candidate] (66.492 ms) : 0, 66492
Remote Config [baseline] (542.984 µs) : 0, 543
Remote Config [candidate] (545.508 µs) : 0, 546
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (8.675 ms) : 0, 8675
Flare Poller [baseline] (3.479 ms) : 0, 3479
Flare Poller [candidate] (3.449 ms) : 0, 3449
IAST [baseline] (27.063 ms) : 0, 27063
IAST [candidate] (26.908 ms) : 0, 26908
section profiling
ProfilingAgent [baseline] (99.325 ms) : 0, 99325
ProfilingAgent [candidate] (100.539 ms) : 0, 100539
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (682.649 ms) : 0, 682649
BytebuddyAgent [candidate] (697.13 ms) : 0, 697130
AgentMeter [baseline] (8.742 ms) : 0, 8742
AgentMeter [candidate] (8.923 ms) : 0, 8923
GlobalTracer [baseline] (216.239 ms) : 0, 216239
GlobalTracer [candidate] (220.688 ms) : 0, 220688
AppSec [baseline] (32.467 ms) : 0, 32467
AppSec [candidate] (33.661 ms) : 0, 33661
Debugger [baseline] (67.587 ms) : 0, 67587
Debugger [candidate] (69.077 ms) : 0, 69077
Remote Config [baseline] (592.656 µs) : 0, 593
Remote Config [candidate] (615.027 µs) : 0, 615
Telemetry [baseline] (8.788 ms) : 0, 8788
Telemetry [candidate] (8.984 ms) : 0, 8984
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.861 ms) : 0, 3861
Profiling [baseline] (99.891 ms) : 0, 99891
Profiling [candidate] (101.115 ms) : 0, 101115
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~617b47a8ad, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (1.178 ms) : 1167, 1190
. : milestone, 1178,
iast (3.188 ms) : 3147, 3230
. : milestone, 3188,
iast_FULL (5.905 ms) : 5845, 5965
. : milestone, 5905,
iast_GLOBAL (3.525 ms) : 3464, 3587
. : milestone, 3525,
profiling (2.029 ms) : 2011, 2047
. : milestone, 2029,
tracing (1.856 ms) : 1841, 1872
. : milestone, 1856,
section candidate
no_agent (1.197 ms) : 1185, 1209
. : milestone, 1197,
iast (3.138 ms) : 3100, 3175
. : milestone, 3138,
iast_FULL (5.832 ms) : 5775, 5890
. : milestone, 5832,
iast_GLOBAL (3.543 ms) : 3486, 3599
. : milestone, 3543,
profiling (2.095 ms) : 2075, 2116
. : milestone, 2095,
tracing (1.939 ms) : 1919, 1958
. : milestone, 1939,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~617b47a8ad, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (17.992 ms) : 17812, 18171
. : milestone, 17992,
appsec (18.319 ms) : 18133, 18505
. : milestone, 18319,
code_origins (17.93 ms) : 17750, 18111
. : milestone, 17930,
iast (17.704 ms) : 17530, 17878
. : milestone, 17704,
profiling (18.899 ms) : 18711, 19087
. : milestone, 18899,
tracing (17.859 ms) : 17684, 18034
. : milestone, 17859,
section candidate
no_agent (18.379 ms) : 18191, 18566
. : milestone, 18379,
appsec (18.591 ms) : 18404, 18778
. : milestone, 18591,
code_origins (17.909 ms) : 17730, 18088
. : milestone, 17909,
iast (17.747 ms) : 17570, 17923
. : milestone, 17747,
profiling (19.87 ms) : 19668, 20072
. : milestone, 19870,
tracing (17.812 ms) : 17634, 17989
. : milestone, 17812,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~617b47a8ad, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (3.693 ms) : 3476, 3911
. : milestone, 3693,
iast (2.251 ms) : 2182, 2321
. : milestone, 2251,
iast_GLOBAL (2.285 ms) : 2215, 2354
. : milestone, 2285,
profiling (2.065 ms) : 2011, 2120
. : milestone, 2065,
tracing (2.055 ms) : 2001, 2109
. : milestone, 2055,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.56 ms) : 2501, 2618
. : milestone, 2560,
iast (2.261 ms) : 2192, 2330
. : milestone, 2261,
iast_GLOBAL (2.294 ms) : 2224, 2364
. : milestone, 2294,
profiling (2.092 ms) : 2036, 2149
. : milestone, 2092,
tracing (2.058 ms) : 2004, 2112
. : milestone, 2058,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~617b47a8ad, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
appsec (14.471 s) : 14471000, 14471000
. : milestone, 14471000,
iast (18.099 s) : 18099000, 18099000
. : milestone, 18099000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
. : milestone, 17902000,
profiling (14.736 s) : 14736000, 14736000
. : milestone, 14736000,
tracing (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
section candidate
no_agent (15.428 s) : 15428000, 15428000
. : milestone, 15428000,
appsec (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
iast (17.84 s) : 17840000, 17840000
. : milestone, 17840000,
iast_GLOBAL (17.78 s) : 17780000, 17780000
. : milestone, 17780000,
profiling (14.817 s) : 14817000, 14817000
. : milestone, 14817000,
tracing (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
|
When multiple probes are created on the same location we previously assume that the context can be shared for all snapshots of the probes. With Capture Expressions we now need to differentiate the captures to respect the probe definitions. We are now creating CapturedContext specifically based on the probe definiton and we are filtering Capture Expressions.
bd61553 to
617b47a
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
8c26540
into
master
What Does This Do
When multiple probes are created on the same location we previously assume that the context can be shared for all snapshots of the probes. With Capture Expressions we now need to differentiate the captures to respect the probe definitions.
We are now creating CapturedContext specifically based on the probe definiton and we are filtering Capture Expressions.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5097