Make MemFDUnixWriterFFM compatible with early SegmentAllocator jdk implementations#10602
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom Feb 16, 2026
Merged
Conversation
mcculls
approved these changes
Feb 16, 2026
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~9bac34bcd3, baseline=1.60.0-SNAPSHOT~ea612c8e95
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064632
Total [baseline] (8.773 s) : 0, 8773258
Agent [candidate] (1.068 s) : 0, 1067852
Total [candidate] (8.813 s) : 0, 8813443
section iast
Agent [baseline] (1.238 s) : 0, 1237834
Total [baseline] (9.396 s) : 0, 9395624
Agent [candidate] (1.234 s) : 0, 1233712
Total [candidate] (9.439 s) : 0, 9438504
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~9bac34bcd3, baseline=1.60.0-SNAPSHOT~ea612c8e95
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (628.718 ms) : 0, 628718
BytebuddyAgent [candidate] (629.411 ms) : 0, 629411
AgentMeter [baseline] (28.95 ms) : 0, 28950
AgentMeter [candidate] (28.993 ms) : 0, 28993
GlobalTracer [baseline] (257.306 ms) : 0, 257306
GlobalTracer [candidate] (258.492 ms) : 0, 258492
AppSec [baseline] (32.875 ms) : 0, 32875
AppSec [candidate] (32.783 ms) : 0, 32783
Debugger [baseline] (60.405 ms) : 0, 60405
Debugger [candidate] (61.625 ms) : 0, 61625
Remote Config [baseline] (631.934 µs) : 0, 632
Remote Config [candidate] (640.349 µs) : 0, 640
Telemetry [baseline] (13.047 ms) : 0, 13047
Telemetry [candidate] (14.794 ms) : 0, 14794
Flare Poller [baseline] (6.117 ms) : 0, 6117
Flare Poller [candidate] (4.562 ms) : 0, 4562
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (800.789 ms) : 0, 800789
BytebuddyAgent [candidate] (796.863 ms) : 0, 796863
AgentMeter [baseline] (11.486 ms) : 0, 11486
AgentMeter [candidate] (11.247 ms) : 0, 11247
GlobalTracer [baseline] (249.555 ms) : 0, 249555
GlobalTracer [candidate] (248.873 ms) : 0, 248873
IAST [baseline] (27.106 ms) : 0, 27106
IAST [candidate] (26.917 ms) : 0, 26917
AppSec [baseline] (34.043 ms) : 0, 34043
AppSec [candidate] (34.939 ms) : 0, 34939
Debugger [baseline] (65.683 ms) : 0, 65683
Debugger [candidate] (65.61 ms) : 0, 65610
Remote Config [baseline] (530.723 µs) : 0, 531
Remote Config [candidate] (560.082 µs) : 0, 560
Telemetry [baseline] (8.563 ms) : 0, 8563
Telemetry [candidate] (8.653 ms) : 0, 8653
Flare Poller [baseline] (3.454 ms) : 0, 3454
Flare Poller [candidate] (3.537 ms) : 0, 3537
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~9bac34bcd3, baseline=1.60.0-SNAPSHOT~ea612c8e95
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066479
Total [baseline] (10.959 s) : 0, 10959207
Agent [candidate] (1.068 s) : 0, 1067852
Total [candidate] (10.907 s) : 0, 10906863
section appsec
Agent [baseline] (1.242 s) : 0, 1242054
Total [baseline] (11.111 s) : 0, 11111453
Agent [candidate] (1.256 s) : 0, 1255951
Total [candidate] (11.146 s) : 0, 11145572
section iast
Agent [baseline] (1.236 s) : 0, 1235895
Total [baseline] (11.367 s) : 0, 11367456
Agent [candidate] (1.234 s) : 0, 1234337
Total [candidate] (11.368 s) : 0, 11368295
section profiling
Agent [baseline] (1.193 s) : 0, 1192753
Total [baseline] (10.988 s) : 0, 10988152
Agent [candidate] (1.194 s) : 0, 1194036
Total [candidate] (11.014 s) : 0, 11014002
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~9bac34bcd3, baseline=1.60.0-SNAPSHOT~ea612c8e95
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (630.535 ms) : 0, 630535
BytebuddyAgent [candidate] (629.709 ms) : 0, 629709
AgentMeter [baseline] (29.093 ms) : 0, 29093
AgentMeter [candidate] (28.972 ms) : 0, 28972
GlobalTracer [baseline] (258.208 ms) : 0, 258208
GlobalTracer [candidate] (257.939 ms) : 0, 257939
AppSec [baseline] (32.673 ms) : 0, 32673
AppSec [candidate] (32.903 ms) : 0, 32903
Debugger [baseline] (62.315 ms) : 0, 62315
Debugger [candidate] (63.731 ms) : 0, 63731
Remote Config [baseline] (614.356 µs) : 0, 614
Remote Config [candidate] (609.737 µs) : 0, 610
Telemetry [baseline] (10.863 ms) : 0, 10863
Telemetry [candidate] (12.882 ms) : 0, 12882
Flare Poller [baseline] (5.489 ms) : 0, 5489
Flare Poller [candidate] (4.558 ms) : 0, 4558
section appsec
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (659.067 ms) : 0, 659067
BytebuddyAgent [candidate] (667.892 ms) : 0, 667892
AgentMeter [baseline] (11.989 ms) : 0, 11989
AgentMeter [candidate] (12.164 ms) : 0, 12164
GlobalTracer [baseline] (259.041 ms) : 0, 259041
GlobalTracer [candidate] (261.469 ms) : 0, 261469
IAST [baseline] (25.128 ms) : 0, 25128
IAST [candidate] (25.788 ms) : 0, 25788
AppSec [baseline] (168.665 ms) : 0, 168665
AppSec [candidate] (169.373 ms) : 0, 169373
Debugger [baseline] (67.211 ms) : 0, 67211
Debugger [candidate] (68.183 ms) : 0, 68183
Remote Config [baseline] (656.39 µs) : 0, 656
Remote Config [candidate] (667.565 µs) : 0, 668
Telemetry [baseline] (9.77 ms) : 0, 9770
Telemetry [candidate] (9.798 ms) : 0, 9798
Flare Poller [baseline] (3.815 ms) : 0, 3815
Flare Poller [candidate] (3.757 ms) : 0, 3757
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (798.163 ms) : 0, 798163
BytebuddyAgent [candidate] (796.854 ms) : 0, 796854
AgentMeter [baseline] (11.312 ms) : 0, 11312
AgentMeter [candidate] (11.292 ms) : 0, 11292
GlobalTracer [baseline] (249.279 ms) : 0, 249279
GlobalTracer [candidate] (248.938 ms) : 0, 248938
IAST [baseline] (26.906 ms) : 0, 26906
IAST [candidate] (26.842 ms) : 0, 26842
AppSec [baseline] (34.087 ms) : 0, 34087
AppSec [candidate] (32.897 ms) : 0, 32897
Debugger [baseline] (66.857 ms) : 0, 66857
Debugger [candidate] (68.19 ms) : 0, 68190
Remote Config [baseline] (545.747 µs) : 0, 546
Remote Config [candidate] (544.833 µs) : 0, 545
Telemetry [baseline] (8.682 ms) : 0, 8682
Telemetry [candidate] (8.639 ms) : 0, 8639
Flare Poller [baseline] (3.489 ms) : 0, 3489
Flare Poller [candidate] (3.499 ms) : 0, 3499
section profiling
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (683.28 ms) : 0, 683280
BytebuddyAgent [candidate] (684.518 ms) : 0, 684518
AgentMeter [baseline] (8.633 ms) : 0, 8633
AgentMeter [candidate] (8.632 ms) : 0, 8632
GlobalTracer [baseline] (216.109 ms) : 0, 216109
GlobalTracer [candidate] (215.919 ms) : 0, 215919
AppSec [baseline] (32.588 ms) : 0, 32588
AppSec [candidate] (32.649 ms) : 0, 32649
Debugger [baseline] (67.707 ms) : 0, 67707
Debugger [candidate] (67.362 ms) : 0, 67362
Remote Config [baseline] (637.894 µs) : 0, 638
Remote Config [candidate] (632.548 µs) : 0, 633
Telemetry [baseline] (9.062 ms) : 0, 9062
Telemetry [candidate] (9.085 ms) : 0, 9085
Flare Poller [baseline] (3.794 ms) : 0, 3794
Flare Poller [candidate] (3.826 ms) : 0, 3826
ProfilingAgent [baseline] (99.745 ms) : 0, 99745
ProfilingAgent [candidate] (100.08 ms) : 0, 100080
Profiling [baseline] (100.327 ms) : 0, 100327
Profiling [candidate] (100.662 ms) : 0, 100662
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~9bac34bcd3, baseline=1.60.0-SNAPSHOT~ea612c8e95
dateFormat X
axisFormat %s
section baseline
no_agent (17.248 ms) : 17076, 17419
. : milestone, 17248,
appsec (18.536 ms) : 18351, 18720
. : milestone, 18536,
code_origins (17.308 ms) : 17139, 17476
. : milestone, 17308,
iast (17.723 ms) : 17546, 17899
. : milestone, 17723,
profiling (18.581 ms) : 18395, 18767
. : milestone, 18581,
tracing (17.579 ms) : 17405, 17753
. : milestone, 17579,
section candidate
no_agent (17.373 ms) : 17200, 17546
. : milestone, 17373,
appsec (18.918 ms) : 18727, 19109
. : milestone, 18918,
code_origins (17.448 ms) : 17278, 17618
. : milestone, 17448,
iast (17.619 ms) : 17444, 17794
. : milestone, 17619,
profiling (18.664 ms) : 18479, 18848
. : milestone, 18664,
tracing (18.013 ms) : 17831, 18195
. : milestone, 18013,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~9bac34bcd3, baseline=1.60.0-SNAPSHOT~ea612c8e95
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1178, 1200
. : milestone, 1189,
iast (3.158 ms) : 3119, 3196
. : milestone, 3158,
iast_FULL (5.753 ms) : 5697, 5810
. : milestone, 5753,
iast_GLOBAL (3.628 ms) : 3568, 3688
. : milestone, 3628,
profiling (2.062 ms) : 2040, 2083
. : milestone, 2062,
tracing (1.791 ms) : 1777, 1805
. : milestone, 1791,
section candidate
no_agent (1.186 ms) : 1175, 1198
. : milestone, 1186,
iast (3.155 ms) : 3108, 3203
. : milestone, 3155,
iast_FULL (5.947 ms) : 5887, 6007
. : milestone, 5947,
iast_GLOBAL (3.462 ms) : 3408, 3515
. : milestone, 3462,
profiling (2.007 ms) : 1990, 2025
. : milestone, 2007,
tracing (1.802 ms) : 1787, 1818
. : milestone, 1802,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~9bac34bcd3, baseline=1.60.0-SNAPSHOT~ea612c8e95
dateFormat X
axisFormat %s
section baseline
no_agent (15.392 s) : 15392000, 15392000
. : milestone, 15392000,
appsec (14.57 s) : 14570000, 14570000
. : milestone, 14570000,
iast (18.439 s) : 18439000, 18439000
. : milestone, 18439000,
iast_GLOBAL (17.772 s) : 17772000, 17772000
. : milestone, 17772000,
profiling (15.091 s) : 15091000, 15091000
. : milestone, 15091000,
tracing (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
section candidate
no_agent (15.534 s) : 15534000, 15534000
. : milestone, 15534000,
appsec (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
iast (18.011 s) : 18011000, 18011000
. : milestone, 18011000,
iast_GLOBAL (17.939 s) : 17939000, 17939000
. : milestone, 17939000,
profiling (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~9bac34bcd3, baseline=1.60.0-SNAPSHOT~ea612c8e95
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.799 ms) : 3578, 4019
. : milestone, 3799,
iast (2.244 ms) : 2175, 2313
. : milestone, 2244,
iast_GLOBAL (2.296 ms) : 2227, 2365
. : milestone, 2296,
profiling (2.067 ms) : 2013, 2121
. : milestone, 2067,
tracing (2.071 ms) : 2017, 2124
. : milestone, 2071,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.508 ms) : 2453, 2562
. : milestone, 2508,
iast (2.248 ms) : 2179, 2316
. : milestone, 2248,
iast_GLOBAL (2.287 ms) : 2218, 2357
. : milestone, 2287,
profiling (2.505 ms) : 2339, 2670
. : milestone, 2505,
tracing (2.055 ms) : 2001, 2108
. : milestone, 2055,
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Contributor
|
Good catch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
SegmentAllocatoris a functional interface that defines theallocatemethod. We were usingallocateFrom, which is a default method introduced in a later version (after 22). However, we still allow the memfd writer to use FFM starting from 22, where that method is not available.In those cases, we encountered:
This PR replaces
allocateFrom(str)with a simpler alternative that works consistently across versions.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.