Fix Windows path parsing in JarScanner#10664
Fix Windows path parsing in JarScanner#10664gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (323.981 µs) : 291, 357
. : milestone, 324,
basic (277.753 µs) : 271, 285
. : milestone, 278,
loop (8.94 ms) : 8933, 8946
. : milestone, 8940,
section candidate
noprobe (323.42 µs) : 265, 382
. : milestone, 323,
basic (272.936 µs) : 267, 279
. : milestone, 273,
loop (8.942 ms) : 8936, 8947
. : milestone, 8942,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 59 metrics, 11 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~4b445c95dd, baseline=1.60.0-SNAPSHOT~d77d632808
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074980
Total [baseline] (8.773 s) : 0, 8773305
Agent [candidate] (1.062 s) : 0, 1062304
Total [candidate] (8.729 s) : 0, 8729495
section iast
Agent [baseline] (1.233 s) : 0, 1233333
Total [baseline] (9.358 s) : 0, 9358085
Agent [candidate] (1.236 s) : 0, 1236094
Total [candidate] (9.411 s) : 0, 9411359
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~4b445c95dd, baseline=1.60.0-SNAPSHOT~d77d632808
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (633.356 ms) : 0, 633356
BytebuddyAgent [candidate] (625.621 ms) : 0, 625621
AgentMeter [baseline] (29.315 ms) : 0, 29315
AgentMeter [candidate] (28.925 ms) : 0, 28925
GlobalTracer [baseline] (260.035 ms) : 0, 260035
GlobalTracer [candidate] (257.006 ms) : 0, 257006
AppSec [baseline] (33.599 ms) : 0, 33599
AppSec [candidate] (32.952 ms) : 0, 32952
Debugger [baseline] (63.538 ms) : 0, 63538
Debugger [candidate] (67.219 ms) : 0, 67219
Remote Config [baseline] (633.5 µs) : 0, 633
Remote Config [candidate] (606.373 µs) : 0, 606
Telemetry [baseline] (10.871 ms) : 0, 10871
Telemetry [candidate] (9.017 ms) : 0, 9017
Flare Poller [baseline] (6.146 ms) : 0, 6146
Flare Poller [candidate] (3.761 ms) : 0, 3761
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (797.273 ms) : 0, 797273
BytebuddyAgent [candidate] (798.813 ms) : 0, 798813
AgentMeter [baseline] (11.325 ms) : 0, 11325
AgentMeter [candidate] (11.377 ms) : 0, 11377
GlobalTracer [baseline] (248.037 ms) : 0, 248037
GlobalTracer [candidate] (248.923 ms) : 0, 248923
AppSec [baseline] (32.419 ms) : 0, 32419
AppSec [candidate] (33.171 ms) : 0, 33171
Debugger [baseline] (67.556 ms) : 0, 67556
Debugger [candidate] (66.774 ms) : 0, 66774
Remote Config [baseline] (540.102 µs) : 0, 540
Remote Config [candidate] (536.284 µs) : 0, 536
Telemetry [baseline] (8.62 ms) : 0, 8620
Telemetry [candidate] (8.694 ms) : 0, 8694
Flare Poller [baseline] (3.431 ms) : 0, 3431
Flare Poller [candidate] (3.52 ms) : 0, 3520
IAST [baseline] (26.979 ms) : 0, 26979
IAST [candidate] (27.103 ms) : 0, 27103
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~4b445c95dd, baseline=1.60.0-SNAPSHOT~d77d632808
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066005
Total [baseline] (10.749 s) : 0, 10748839
Agent [candidate] (1.076 s) : 0, 1076441
Total [candidate] (10.817 s) : 0, 10817457
section appsec
Agent [baseline] (1.239 s) : 0, 1238663
Total [baseline] (10.98 s) : 0, 10979780
Agent [candidate] (1.239 s) : 0, 1238519
Total [candidate] (11.095 s) : 0, 11095044
section iast
Agent [baseline] (1.232 s) : 0, 1232307
Total [baseline] (11.148 s) : 0, 11148011
Agent [candidate] (1.232 s) : 0, 1232413
Total [candidate] (11.185 s) : 0, 11184543
section profiling
Agent [baseline] (1.189 s) : 0, 1189307
Total [baseline] (10.826 s) : 0, 10826026
Agent [candidate] (1.198 s) : 0, 1198161
Total [candidate] (11.098 s) : 0, 11097528
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~4b445c95dd, baseline=1.60.0-SNAPSHOT~d77d632808
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (628.092 ms) : 0, 628092
BytebuddyAgent [candidate] (634.113 ms) : 0, 634113
AgentMeter [baseline] (28.998 ms) : 0, 28998
AgentMeter [candidate] (29.393 ms) : 0, 29393
GlobalTracer [baseline] (257.406 ms) : 0, 257406
GlobalTracer [candidate] (259.992 ms) : 0, 259992
AppSec [baseline] (32.937 ms) : 0, 32937
AppSec [candidate] (33.559 ms) : 0, 33559
Debugger [baseline] (63.892 ms) : 0, 63892
Debugger [candidate] (64.493 ms) : 0, 64493
Remote Config [baseline] (623.956 µs) : 0, 624
Remote Config [candidate] (620.915 µs) : 0, 621
Telemetry [baseline] (10.666 ms) : 0, 10666
Telemetry [candidate] (11.578 ms) : 0, 11578
Flare Poller [baseline] (6.262 ms) : 0, 6262
Flare Poller [candidate] (5.326 ms) : 0, 5326
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (657.688 ms) : 0, 657688
BytebuddyAgent [candidate] (657.524 ms) : 0, 657524
AgentMeter [baseline] (11.928 ms) : 0, 11928
AgentMeter [candidate] (11.905 ms) : 0, 11905
GlobalTracer [baseline] (258.259 ms) : 0, 258259
GlobalTracer [candidate] (258.169 ms) : 0, 258169
IAST [baseline] (25.28 ms) : 0, 25280
IAST [candidate] (25.287 ms) : 0, 25287
AppSec [baseline] (167.743 ms) : 0, 167743
AppSec [candidate] (167.791 ms) : 0, 167791
Debugger [baseline] (66.887 ms) : 0, 66887
Debugger [candidate] (66.802 ms) : 0, 66802
Remote Config [baseline] (632.483 µs) : 0, 632
Remote Config [candidate] (648.006 µs) : 0, 648
Telemetry [baseline] (9.426 ms) : 0, 9426
Telemetry [candidate] (9.494 ms) : 0, 9494
Flare Poller [baseline] (3.681 ms) : 0, 3681
Flare Poller [candidate] (3.706 ms) : 0, 3706
section iast
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (795.891 ms) : 0, 795891
BytebuddyAgent [candidate] (796.136 ms) : 0, 796136
AgentMeter [baseline] (11.243 ms) : 0, 11243
AgentMeter [candidate] (11.285 ms) : 0, 11285
GlobalTracer [baseline] (247.483 ms) : 0, 247483
GlobalTracer [candidate] (247.073 ms) : 0, 247073
IAST [baseline] (27.128 ms) : 0, 27128
IAST [candidate] (27.051 ms) : 0, 27051
AppSec [baseline] (34.073 ms) : 0, 34073
AppSec [candidate] (34.007 ms) : 0, 34007
Debugger [baseline] (66.752 ms) : 0, 66752
Debugger [candidate] (66.854 ms) : 0, 66854
Remote Config [baseline] (538.76 µs) : 0, 539
Remote Config [candidate] (540.778 µs) : 0, 541
Telemetry [baseline] (8.58 ms) : 0, 8580
Telemetry [candidate] (8.749 ms) : 0, 8749
Flare Poller [baseline] (3.457 ms) : 0, 3457
Flare Poller [candidate] (3.518 ms) : 0, 3518
section profiling
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (681.055 ms) : 0, 681055
BytebuddyAgent [candidate] (684.965 ms) : 0, 684965
AgentMeter [baseline] (8.595 ms) : 0, 8595
AgentMeter [candidate] (8.645 ms) : 0, 8645
GlobalTracer [baseline] (215.802 ms) : 0, 215802
GlobalTracer [candidate] (217.742 ms) : 0, 217742
AppSec [baseline] (32.541 ms) : 0, 32541
AppSec [candidate] (33.062 ms) : 0, 33062
Debugger [baseline] (67.484 ms) : 0, 67484
Debugger [candidate] (67.92 ms) : 0, 67920
Remote Config [baseline] (627.138 µs) : 0, 627
Remote Config [candidate] (653.517 µs) : 0, 654
Telemetry [baseline] (8.971 ms) : 0, 8971
Telemetry [candidate] (9.041 ms) : 0, 9041
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.805 ms) : 0, 3805
ProfilingAgent [baseline] (98.72 ms) : 0, 98720
ProfilingAgent [candidate] (100.34 ms) : 0, 100340
Profiling [baseline] (99.293 ms) : 0, 99293
Profiling [candidate] (100.925 ms) : 0, 100925
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~4b445c95dd, baseline=1.60.0-SNAPSHOT~d77d632808
dateFormat X
axisFormat %s
section baseline
no_agent (1.179 ms) : 1168, 1191
. : milestone, 1179,
iast (3.231 ms) : 3188, 3274
. : milestone, 3231,
iast_FULL (5.548 ms) : 5492, 5603
. : milestone, 5548,
iast_GLOBAL (3.581 ms) : 3526, 3636
. : milestone, 3581,
profiling (2.002 ms) : 1984, 2020
. : milestone, 2002,
tracing (1.758 ms) : 1745, 1772
. : milestone, 1758,
section candidate
no_agent (1.179 ms) : 1167, 1190
. : milestone, 1179,
iast (3.215 ms) : 3169, 3261
. : milestone, 3215,
iast_FULL (6.023 ms) : 5962, 6085
. : milestone, 6023,
iast_GLOBAL (3.752 ms) : 3694, 3809
. : milestone, 3752,
profiling (2.059 ms) : 2041, 2078
. : milestone, 2059,
tracing (1.798 ms) : 1783, 1812
. : milestone, 1798,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~4b445c95dd, baseline=1.60.0-SNAPSHOT~d77d632808
dateFormat X
axisFormat %s
section baseline
no_agent (17.036 ms) : 16869, 17203
. : milestone, 17036,
appsec (19.037 ms) : 18846, 19228
. : milestone, 19037,
code_origins (17.419 ms) : 17245, 17592
. : milestone, 17419,
iast (17.767 ms) : 17591, 17943
. : milestone, 17767,
profiling (18.386 ms) : 18204, 18569
. : milestone, 18386,
tracing (17.438 ms) : 17264, 17611
. : milestone, 17438,
section candidate
no_agent (17.914 ms) : 17728, 18100
. : milestone, 17914,
appsec (18.674 ms) : 18482, 18867
. : milestone, 18674,
code_origins (17.508 ms) : 17336, 17680
. : milestone, 17508,
iast (17.468 ms) : 17299, 17638
. : milestone, 17468,
profiling (18.662 ms) : 18475, 18849
. : milestone, 18662,
tracing (17.685 ms) : 17507, 17863
. : milestone, 17685,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~4b445c95dd, baseline=1.60.0-SNAPSHOT~d77d632808
dateFormat X
axisFormat %s
section baseline
no_agent (15.511 s) : 15511000, 15511000
. : milestone, 15511000,
appsec (15.195 s) : 15195000, 15195000
. : milestone, 15195000,
iast (18.818 s) : 18818000, 18818000
. : milestone, 18818000,
iast_GLOBAL (18.129 s) : 18129000, 18129000
. : milestone, 18129000,
profiling (15.524 s) : 15524000, 15524000
. : milestone, 15524000,
tracing (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
section candidate
no_agent (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
appsec (15.274 s) : 15274000, 15274000
. : milestone, 15274000,
iast (18.109 s) : 18109000, 18109000
. : milestone, 18109000,
iast_GLOBAL (17.806 s) : 17806000, 17806000
. : milestone, 17806000,
profiling (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
tracing (14.556 s) : 14556000, 14556000
. : milestone, 14556000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~4b445c95dd, baseline=1.60.0-SNAPSHOT~d77d632808
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.761 ms) : 3539, 3982
. : milestone, 3761,
iast (2.245 ms) : 2177, 2314
. : milestone, 2245,
iast_GLOBAL (2.293 ms) : 2224, 2362
. : milestone, 2293,
profiling (2.074 ms) : 2020, 2129
. : milestone, 2074,
tracing (2.049 ms) : 1996, 2102
. : milestone, 2049,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.768 ms) : 3547, 3990
. : milestone, 3768,
iast (2.25 ms) : 2182, 2318
. : milestone, 2250,
iast_GLOBAL (2.289 ms) : 2220, 2358
. : milestone, 2289,
profiling (2.077 ms) : 2022, 2131
. : milestone, 2077,
tracing (2.064 ms) : 2010, 2118
. : milestone, 2064,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Use Paths.get(URI) instead of Paths.get(String) to correctly handle Windows drive letters in CodeSource locations (e.g. file:/C:/...). [DYNIS-50]
0947c9e to
4b445c9
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
0322296
into
master
What Does This Do
Use Paths.get(URI) instead of Paths.get(String) to correctly handle Windows drive letters in CodeSource locations (e.g. file:/C:/...).
Motivation
Fixes a reported exception thrown by windows path parser
See DYNIS-50 for full report
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DYNIS-50
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.