Fix: EOL was missing for custom log lines with Serial.printf#421
Merged
mathieucarbou merged 1 commit intomainfrom Apr 7, 2026
Merged
Fix: EOL was missing for custom log lines with Serial.printf#421mathieucarbou merged 1 commit intomainfrom
mathieucarbou merged 1 commit intomainfrom
Conversation
mathieucarbou
force-pushed
the
fix-logging
branch
from
e182268 to
e559652
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR ensures log lines emitted via Serial.printf end with an EOL, improving readability and preventing concatenated log output.
Changes:
- Append
\ntoSerial.printf-based logging macros so each log call ends in a newline. - Restructure logging preprocessor branches to separate custom logging from built-in debug/framework logging.
- Fix a
printftype mismatch in a verbose websocket log by castingplentouint32_tfor thePRIu32format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/AsyncWebSocket.cpp | Adjusts a verbose log call to match PRIu32 formatting and improves readability by splitting arguments. |
| src/AsyncWebServerLogging.h | Adds newline terminators to Serial.printf log macros and refactors preprocessor branching for logging modes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mathieucarbou
force-pushed
the
fix-logging
branch
from
e559652 to
e484fc5
Compare
mathieucarbou
force-pushed
the
fix-logging
branch
from
e484fc5 to
75625c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.