LAMA to Dask: arithmetic, logical & comparison operators#409
Conversation
davidhassell
left a comment
There was a problem hiding this comment.
Thanks, Sadie. A quick review, as I know that there is more work to done ...
notably since I am about to add a commit or two applying elemwise calls to the operations that give the results
I don't really understand what these elemwise calls could be for - am I missing something?
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
|
Thanks for all of your feedback (so far) @davidhassell, which I have now addressed fully as far as I can tell. Unless you have further comments, this should be ready to merge now, though I would like to also first check that I was OK to 'deprecate' our custom function |
|
(CI jobs failing or cancelled due to trying to use the wrong |
|
Hi Sadie - all looks good to me, thanks. As |
Convert all of the arithmetic, logical & comparison operators from LAMA to Dask. Please cross-reference with #295 for the precise listing of methods being migrated here, if necessary.