Fix test_decorators issue by setting correct assertLogs levels#424
Merged
davidhassell merged 2 commits intoNCAS-CMS:masterfrom Jul 18, 2022
Merged
Fix test_decorators issue by setting correct assertLogs levels#424davidhassell merged 2 commits intoNCAS-CMS:masterfrom
davidhassell merged 2 commits intoNCAS-CMS:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 73.80% 74.25% +0.46%
==========================================
Files 85 88 +3
Lines 19179 19713 +534
==========================================
+ Hits 14153 14636 +483
- Misses 5026 5077 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
sadielbartholomew
approved these changes
Jul 18, 2022
Member
There was a problem hiding this comment.
All good save for a tweak to fix the changelog link. Notably, the full test suite passes locally with both my Python 3.10 and 3.9 conda environments.
You got at the test_decorators fix for cf-python before I could (popped it on my TODO list after completing the cfdm equivalent, to tackle after finishing up more urgent tasks), so thanks since I can tick that off now 😃
Please merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #419
See NCAS-CMS/cfdm#197 for details.