Skip to content

Fix DimensionCoordinate.create_bounds for cyclic coordinates & improve docs#523

Merged
davidhassell merged 12 commits intoNCAS-CMS:masterfrom
davidhassell:create-bounds-docs
Dec 20, 2022
Merged

Fix DimensionCoordinate.create_bounds for cyclic coordinates & improve docs#523
davidhassell merged 12 commits intoNCAS-CMS:masterfrom
davidhassell:create-bounds-docs

Conversation

@davidhassell
Copy link
Copy Markdown
Collaborator

Fixes #514

@davidhassell davidhassell added this to the 3.14.0 milestone Dec 13, 2022
Copy link
Copy Markdown
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed as a logical fix for the bug with a very thorough and clear update to the docstring 💯. I've highlighted some typos (and asked one random question) but other than those this is good to merge in my eyes. Thanks.

davidhassell and others added 7 commits December 20, 2022 16:03
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell davidhassell merged commit 741d611 into NCAS-CMS:master Dec 20, 2022
@davidhassell davidhassell deleted the create-bounds-docs branch December 20, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Voronoi bounds from DimensionCoordinate.create_bounds for cyclic coordinates

2 participants