Fix #5223 - update conan ruby to relax MSC_VER restriction#5224
Merged
wenyikuang merged 1 commit intodevelopfrom Oct 31, 2024
Merged
Fix #5223 - update conan ruby to relax MSC_VER restriction#5224wenyikuang merged 1 commit intodevelopfrom
wenyikuang merged 1 commit intodevelopfrom
Conversation
Note: the armv8 macos14 builds failed, and I don't understand why... So maybe we'll need to figure that out...
Collaborator
|
CI Results for df6de15:
|
Collaborator
Author
|
I hit this today again with MSVC > 1940 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Note: the macos apple-clang-14 armv8 builds failed (the apple-clang-15 worked), and I don't understand why (what changed? Probably just from the GHA runners themselves...)... So maybe we'll need to figure that out later if we get people using apple-clang14 and not 15 that complain they can't build https://github.com/jmarrec/conan-recipes/actions/runs/9545192414/job/26305457773
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.