Incorrect mesh mapping between BeamDyn and ServoDyn for Blade Structural Controller#2817
Merged
deslaughter merged 4 commits intoOpenFAST:dev-tcfrom May 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the mesh mapping initialization for the blade structural controller by fixing the indexing into the BeamDyn and ServoDyn mapping structures.
- Updated the RoutineName from "InitMappings_BD" to "InitMappings_SrvD".
- Corrected the indexing in the MapMotionMesh call by replacing DstMod%Ins with SrcMod%Ins in both source and destination arrays.
mayankchetan
approved these changes
May 16, 2025
andrew-platt
approved these changes
May 16, 2025
Collaborator
Author
|
It would probably be good to do. Would as short version of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
The mesh mapping initialization in
InitMappings_SrvDwas incorrect for the blade structural controller motion between BeamDyn and ServoDyn. Specifically, the indexing into theBD%y%BldMotionandSrvD%u%BStCMotionMeshstructs based on the BeamDyn instance was wrong and has been corrected in this PR.Impacted areas of the software
InitMappings_SrvDfunction inFAST_Mapping.f90.