SrvD: bugfix linearization of StC _dYdx was not using x_perturb#2942
Merged
andrew-platt merged 2 commits intoOpenFAST:rc-4.1.2from Aug 4, 2025
Merged
SrvD: bugfix linearization of StC _dYdx was not using x_perturb#2942andrew-platt merged 2 commits intoOpenFAST:rc-4.1.2from
andrew-platt merged 2 commits intoOpenFAST:rc-4.1.2from
Conversation
This error was reported through e-mail.
jjonkman
approved these changes
Aug 4, 2025
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
Thanks for fixing this bug! Makes sense to me!
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
The linearization of ServoDyn structural controls was incorrectly calculating the
dYdxterms. The perturbed values of continuous states,x, was not getting used in theStC_CalcOutputcall which incorrectly would show no effect of continuous state perturbation on the outputs. This was reported by an external user through e-mail.I have a vague memory of some discussion related to this, but don't recall the details now.
Related issue, if one exists
Unknown - simple search didn't reveal anything.
Impacted areas of the software
ServoDyn linearization when structural controls are used.
Additional supporting information
This error was reported through e-mail.
Test results, if applicable
The
StC_test_OC4Semi_Linear_NacandStC_test_OC4Semi_Linear_Towcases will likely change slightly.