[OLAF] Implementation of a source panel method#2945
Merged
deslaughter merged 6 commits intoOpenFAST:dev-tcfrom Dec 19, 2025
Merged
[OLAF] Implementation of a source panel method#2945deslaughter merged 6 commits intoOpenFAST:dev-tcfrom
deslaughter merged 6 commits intoOpenFAST:dev-tcfrom
Conversation
jjonkman
requested changes
Aug 29, 2025
Collaborator
jjonkman
left a comment
There was a problem hiding this comment.
Review of the new input file documentation only.
bjonkman
reviewed
Sep 2, 2025
Contributor
|
@ebranlard Has the sphere unit test been added already, or is that still to be completed? |
Contributor
Author
The r-test for the potential flow about a sphere is now added, see here |
26fc588 to
5dabe9b
Compare
Collaborator
|
One of the regression tests is failing due to an incomplete preceding test (restart case). This is unrelated to the changes here. |
jjonkman
approved these changes
Dec 19, 2025
Collaborator
jjonkman
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments and updating the acknowledgements!
Contributor
Author
|
Thank you for the fast turnaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a draft
Feature or improvement description
Impacted areas of the software
AeroDyn / OLAF
Supporting information
FVW_BiotSavart.f90FVW_Subswith the suffix:srcPnl_T_SrcPanl*similar toT_SgmtandT_Part.Test results, if applicable
A unittest is included as part of
FVW_Teststo check that the Cp of a sphere match the analytical value.