Skip to content

[BugFix] AD: DTAero from input file was ignored#3227

Merged
andrew-platt merged 1 commit intoOpenFAST:rc-4.2.1from
andrew-platt:b/AD_substep
Mar 2, 2026
Merged

[BugFix] AD: DTAero from input file was ignored#3227
andrew-platt merged 1 commit intoOpenFAST:rc-4.2.1from
andrew-platt:b/AD_substep

Conversation

@andrew-platt
Copy link
Copy Markdown
Collaborator

Ready to merge

Feature or improvement description
When converting AeroDyn to use the FileInfoType for file parsing with PR #643, the primary input file reading was split from the ReadInputFiles routine. The value for DTAero is then read with ParseVarWDefault to populate InputFileData%DTAero. However, this DTAero was getting overwritten during at the beginning of the ReadInputFiles call with the Interval passed from the glue code. The result was DTAero from the input file was always replaced with the glue code timestep, so sub-cycling could not occur.

This affects all OpenFAST versions from 3.0.0 until now.

Related GitHub Issue/PR
#643

Impacted areas of the software
AeroDyn DTAero and sub-cycling of AeroDyn within OpenFAST.

Additional supporting information
None

Generative AI usage
None

Test results, if applicable
None

@andrew-platt andrew-platt requested a review from deslaughter March 2, 2026 18:07
@andrew-platt andrew-platt self-assigned this Mar 2, 2026
@andrew-platt andrew-platt added this to the v4.2.1 milestone Mar 2, 2026
@andrew-platt andrew-platt merged commit 8acb31d into OpenFAST:rc-4.2.1 Mar 2, 2026
12 checks passed
@deslaughter deslaughter deleted the b/AD_substep branch March 2, 2026 23:25
@andrew-platt andrew-platt mentioned this pull request Mar 10, 2026
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants