SeaState: Small change in WaveTp logic#3231
Merged
andrew-platt merged 2 commits intoOpenFAST:devfrom Mar 5, 2026
Merged
Conversation
Collaborator
|
Does this apply to 4.2 as well? |
Contributor
Author
|
Yes, it applies to any SeaState. This condition should have been always there. |
Collaborator
|
Backport to 4.2.1 |
Contributor
|
@RBergua Thanks for fixing this. It looks good to me. Maybe change to |
Contributor
Author
|
Good point! I just updated it to |
andrew-platt
approved these changes
Mar 5, 2026
luwang00
approved these changes
Mar 5, 2026
andrew-platt
added a commit
that referenced
this pull request
Mar 5, 2026
…2.1_backport backport of #3231 - SS WaveTp logic
This was referenced Mar 10, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
In SeaState, the peak-spectral period parameter (
WaveTp) should only play a role when usingWaveMod= 1 or 2 (regular or irregular waves).However, nowadays, there is a check regardless of the wave option selected. For example, when using
WaveMod= 5 (externally generated wave-elevation time series), I get:This modification checks for a valid
WaveTponly ifWaveMod= 1 or 2.