Fix complex scenarios with lists and admonitions#1006
Merged
waylan merged 4 commits intoPython-Markdown:masterfrom Jul 26, 2020
Merged
Fix complex scenarios with lists and admonitions#1006waylan merged 4 commits intoPython-Markdown:masterfrom
waylan merged 4 commits intoPython-Markdown:masterfrom
Conversation
Add better logic to admonitions to account for more complex list cases Fixes Python-Markdown#1004
facelessuser
added
the
work-in-progress
- If we match the header, we don't need to get the sibling - If we tested and found the sibling, cache the info so that when we run the processor, we get the sibling we just found. - Also save away stripped indentation that we calculated when verifying the last sibling so we can quickly format the text we need to process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add better logic to admonitions to account for more complex list cases
Fixes #1004