Fix complex scenarios with definition, ordered, and unordered lists#1007
Fix complex scenarios with definition, ordered, and unordered lists#1007waylan merged 3 commits intoPython-Markdown:masterfrom
Conversation
|
I want to look into why coverage isn't like I expect. It seems the very minimum to get the tests to pass is to add |
The entire test suite never exercises 'create_item', not the original in blockprocessors or the override in def_list. Uncertain of how to even trigger the code to test logic. Remove changes as they are untestable currently.
|
@waylan I removed changes to Regardless, it makes no sense for me to alter code that can not be validated, isn't validated, and probably never actually run. I figure if a scenario comes up in the future that can actually trigger the code, and there is a problem, we can fix it then. At this point, I think I'm done with this pull. |
|
I did a quick search, and it appears the only place markdown/markdown/blockprocessors.py Lines 203 to 205 in be7ba7b As it turns out, line 204 is listed among the lines with no test coverage, even for In any event, thanks for the work on this. |
|
It's possible that at some point it did get exercised. Whatever the case, whether just a safety net, or made that way over time, it doesn't seem necessary today 🙂. |
Adds logic to the definition list indentation parser to be aware of unordered and ordered lists.
Fixes #918