Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: RocketPy-Team/RocketPy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.12.0
Choose a base ref
...
head repository: RocketPy-Team/RocketPy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.12.1
Choose a head ref
  • 1 commit
  • 17 files changed
  • 8 contributors

Commits on Apr 6, 2026

  1. HOTFIX: Migrate Forecasts to UCAR THREDDS (#943)

    * BUG: Fix hard-coded radius value for parachute added mass calculation (#889)
    
    * Fix hard-coded radius value for parachute added mass calculation
    
    Calculate radius from cd_s using a typical hemispherical parachute drag
    coefficient (1.4) when radius is not explicitly provided. This fixes
    drift distance calculations for smaller parachutes like drogues.
    
    Formula: R = sqrt(cd_s / (Cd * π))
    
    Closes #860
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Address code review: improve docstrings and add explicit None defaults
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Add CHANGELOG entry for PR #889
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Update rocket.add_parachute to use radius=None for consistency
    
    Changed the default radius from 1.5 to None in the add_parachute method
    to match the Parachute class behavior. This ensures consistent automatic
    radius calculation from cd_s across both APIs.
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation
    
    Fix hard-coded radius value for parachute added mass calculation
    
    Calculate radius from cd_s using a typical hemispherical parachute drag
    coefficient (1.4) when radius is not explicitly provided. This fixes
    drift distance calculations for smaller parachutes like drogues.
    
    Formula: R = sqrt(cd_s / (Cd * π))
    
    Closes #860
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Add CHANGELOG entry for PR #889
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation
    
    MNT: Extract noise initialization to fix pylint too-many-statements in Parachute.__init__
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * Refactor environment method access in controller test for clarity
    
    * fix pylint
    
    * fix comments
    
    * avoid breaking change with drag_coefficient
    
    * reafactors Parachute.__init__ method
    
    * fix tests
    
    ---------
    
    Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <guilherme_fernandes@usp.br>
    
    * ENH: get changes from BUG: All NOAA NOMADS Dependent Atmosphere Models Broken
    Fixes #933
    
    * ENH: Add guidelines for simulation safety, Sphinx documentation, and pytest standards (GitHub Copilot) (#937)
    
    * REL: bump version to 1.12
    
    * ENH: Add explicit timeouts to ThrustCurve API requests and update changelog (#940)
    
    * Initial plan
    
    * ENH: Add explicit timeouts to ThrustCurve API requests
    
    Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
    
    * DOC: Add timeout fix PR to changelog
    
    Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
    Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
    
    * ENH: Restore power_off/on_drag as Function objects; add _input attributes for raw user input and update changelog (#941)
    
    * Initial plan
    
    * ENH: Restore power_off/on_drag as Function, add _input attributes for raw user input
    
    Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
    
    * DOC: Add PR #941 compatibility fix to changelog
    
    Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
    
    * Update rocketpy/rocket/rocket.py
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * MNT: ruff pylint
    
    ---------
    
    Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
    Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    Co-authored-by: MateusStano <mateusstano@usp.br>
    
    * MNT: Remove unused imports and deprecated functions from mathutils/function.py
    
    * BUG: Readd SourceType enumeration for function source types and clean up imports
    
    * BUG: Fix incorrect Jacobian in `only_radial_burn` branch of `SolidMotor.evaluate_geometry` (#944)
    
    * Initial plan
    
    * BUG: Fix incorrect Jacobian in only_radial_burn branch of evaluate_geometry
    
    Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
    Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
    
    * ENH: move weathercocking_coeff to PointMassRockt
    
    * MNT: ruff
    
    * MNT: fix cyclic import
    
    * BUG: Add wraparound logic for wind direction in environment plots (#939)
    
    * chore: added personal toolkit files
    
    * update branch name in workflow
    
    * chore: update toolkit files
    
    * Fix: add wraparound logic for wind direction and related tests
    
    * style: fix ruff formatting
    
    * Remove unused import
    
    Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
    
    * refactor: move repetitive logic into helper method
    
    * fix: update test logic in test_environment
    
    * add changelog entry
    
    ---------
    
    Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * MNT: add numpy import to test_environment.py
    
    * MNT: rename constant for wraparound threshold in _break_direction_wraparound method
    
    * ENH: Adaptive Monte Carlo via Convergence Criteria (#922)
    
    * ENH: added a new function (simulate_convergence)
    
    * DOC: added a cell to show simulate_convergence function usage
    
    * TST: integration test for simulate_convergence
    
    * DOC: updated changelog for this PR
    
    * ENH: ran black to lint intg test file
    
    * new fixes thx to copilot comments
    
    * linted rocketpy/simulation/monte_carlo.py
    
    ---------
    
    Co-authored-by: Malmahrouqi3 <mohdsaid497566@gmail.com>
    
    * DOC: add latitude range in docs
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * MNT: remove unnecessary pylint warning
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * MNT: remove unnecessary pylint warning
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * DOC: correctly link to WeatherModelMapping
    
    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    
    * DOCS: checked todo
    
    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    
    * ENH: address copilot comments
    
    * TST: improve tests
    
    * ENH: get changes from BUG: All NOAA NOMADS Dependent Atmosphere Models Broken
    Fixes #933
    
    * BUG: Fix hard-coded radius value for parachute added mass calculation (#889)
    
    * Fix hard-coded radius value for parachute added mass calculation
    
    Calculate radius from cd_s using a typical hemispherical parachute drag
    coefficient (1.4) when radius is not explicitly provided. This fixes
    drift distance calculations for smaller parachutes like drogues.
    
    Formula: R = sqrt(cd_s / (Cd * π))
    
    Closes #860
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Address code review: improve docstrings and add explicit None defaults
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Add CHANGELOG entry for PR #889
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Update rocket.add_parachute to use radius=None for consistency
    
    Changed the default radius from 1.5 to None in the add_parachute method
    to match the Parachute class behavior. This ensures consistent automatic
    radius calculation from cd_s across both APIs.
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation
    
    Fix hard-coded radius value for parachute added mass calculation
    
    Calculate radius from cd_s using a typical hemispherical parachute drag
    coefficient (1.4) when radius is not explicitly provided. This fixes
    drift distance calculations for smaller parachutes like drogues.
    
    Formula: R = sqrt(cd_s / (Cd * π))
    
    Closes #860
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Add CHANGELOG entry for PR #889
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation
    
    MNT: Extract noise initialization to fix pylint too-many-statements in Parachute.__init__
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * Refactor environment method access in controller test for clarity
    
    * fix pylint
    
    * fix comments
    
    * avoid breaking change with drag_coefficient
    
    * reafactors Parachute.__init__ method
    
    * fix tests
    
    ---------
    
    Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <guilherme_fernandes@usp.br>
    
    * ENH: Add guidelines for simulation safety, Sphinx documentation, and pytest standards (GitHub Copilot) (#937)
    
    * REL: bump version to 1.12
    
    * BUG: Add wraparound logic for wind direction in environment plots (#939)
    
    * chore: added personal toolkit files
    
    * update branch name in workflow
    
    * chore: update toolkit files
    
    * Fix: add wraparound logic for wind direction and related tests
    
    * style: fix ruff formatting
    
    * Remove unused import
    
    Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
    
    * refactor: move repetitive logic into helper method
    
    * fix: update test logic in test_environment
    
    * add changelog entry
    
    ---------
    
    Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * MNT: add numpy import to test_environment.py
    
    * MNT: rename constant for wraparound threshold in _break_direction_wraparound method
    
    * DOC: add latitude range in docs
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * MNT: remove unnecessary pylint warning
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * MNT: remove unnecessary pylint warning
    
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    
    * ENH: address copilot comments
    
    * TST: improve tests
    
    * DOC: correctly link to WeatherModelMapping
    
    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    
    * DOCS: checked todo
    
    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    
    * ENH: Adaptive Monte Carlo via Convergence Criteria (#922)
    
    * ENH: added a new function (simulate_convergence)
    
    * DOC: added a cell to show simulate_convergence function usage
    
    * TST: integration test for simulate_convergence
    
    * DOC: updated changelog for this PR
    
    * ENH: ran black to lint intg test file
    
    * new fixes thx to copilot comments
    
    * linted rocketpy/simulation/monte_carlo.py
    
    ---------
    
    Co-authored-by: Malmahrouqi3 <mohdsaid497566@gmail.com>
    
    * DEV: remove unwanted changes from develop
    
    * DEV: Update for hotfix
    
    * TST: add tests
    
    * MNT: remove changes from develop again
    
    * MNT: Refactor longitude and latitude index functions
    
    * MNT: ruff
    
    ---------
    
    Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
    Co-authored-by: Gui-FernandesBR <guilherme_fernandes@usp.br>
    Co-authored-by: Khushal Kottaru <khushal.kottaru@gmail.com>
    Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
    Co-authored-by: Mohammed S. Al-Mahrouqi <malmahrouqi3@gatech.edu>
    Co-authored-by: Malmahrouqi3 <mohdsaid497566@gmail.com>
    8 people authored Apr 6, 2026
    Configuration menu
    Copy the full SHA
    cb15a39 View commit details
    Browse the repository at this point in the history
Loading