Conversation
tarcieri
approved these changes
Aug 16, 2022
|
After merging, could you create a new (minor) release of this crate? |
Member
Author
|
@brocaar |
|
I'm currently recompiling with cpufeatures updated to v0.2.3, I will let you know if this solves the issue. |
|
@newpavlov I can confirm that this update solved RustCrypto/hashes#386. Thanks for your support! |
This was referenced Aug 29, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must do it according to the Intel manual. Our non-conformance has caused issues with the
sha2crate.Strictly speaking, during detection of AVX we also should use XGETBV to check whether XMM and YMM states are enabled by OS, but I think it's worth to do it later in a separate PR.
cc @brocaar