add videos to playlist from chat#316
Closed
csandras05 wants to merge 0 commit intoSyncplay:masterfrom
Closed
Conversation
Contributor
|
Thanks for the PR. It might be better if users could add any file to the playlist (as users can when you edit the playlist), which could be useful if they are still downloading the file they were hoping to play. I've not tested it much, but I think this can be done by making the following changes:
Note: The check in Some language issues:
|
Merged
Et0h
pushed a commit
that referenced
this pull request
Sep 13, 2020
* add videos to playlist from chat * add urls to playlist * add files in media directory to playlist * add commands to show the playlist and select an index * add command to delete files from the playlist * show selected index in playlist * fix adding files with queue command in GUI mode * start indexing the playlist at 1 or at least that's what it would look like to the user * start all commands related to playlist with `q` Co-authored-by: kiscs <csandras05@gmail.com>
albertosottile
pushed a commit
to albertosottile/syncplay
that referenced
this pull request
Sep 30, 2020
…and Syncplay#319 * add videos to playlist from chat * add urls to playlist * add files in media directory to playlist * add commands to show the playlist and select an index * add command to delete files from the playlist * show selected index in playlist * fix adding files with queue command in GUI mode * start indexing the playlist at 1 or at least that's what it would look like to the user * start all commands related to playlist with `q` Co-authored-by: kiscs <csandras05@gmail.com>
albertosottile
pushed a commit
to albertosottile/syncplay
that referenced
this pull request
Sep 30, 2020
…and Syncplay#319 * add videos to playlist from chat * add urls to playlist * add files in media directory to playlist * add commands to show the playlist and select an index * add command to delete files from the playlist * show selected index in playlist * fix adding files with queue command in GUI mode * start indexing the playlist at 1 or at least that's what it would look like to the user * start all commands related to playlist with `q` Co-authored-by: kiscs <csandras05@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Partially) solves issue #262 - adding videos to playlist from terminal (without gui) is still not possible.