Skip to content

Fix failing and flaky E2E tests#360

Merged
dkotter merged 3 commits intoWordPress:developfrom
dkotter:fix/flaky-image-edit-test
Apr 1, 2026
Merged

Fix failing and flaky E2E tests#360
dkotter merged 3 commits intoWordPress:developfrom
dkotter:fix/flaky-image-edit-test

Conversation

@dkotter
Copy link
Copy Markdown
Collaborator

@dkotter dkotter commented Apr 1, 2026

What?

Fixes flaky E2E image edit tests. Also updates some tests based on the new Connectors markup that's in WordPress trunk

Why?

Some of the image edit E2E tests tend to be flaky, sometimes passing, sometimes not. Seems to be most flaky in our pipeline runs.

Also have some tests that started failing due to markup changes to the Connectors screen recently merged into WordPress trunk

How?

Ensure we wait properly for click events to happen. Update our selectors

Use of AI Tools

Used Cursor running GPT-5.3 Codex to investigate and fix the issue. Ran E2E tests myself locally multiple times to verify the fix

Testing Instructions

n/a. Just ensure E2E tests pass

Open WordPress Playground Preview

@dkotter dkotter added this to the 0.7.0 milestone Apr 1, 2026
@dkotter dkotter self-assigned this Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dkotter <dkotter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.70%. Comparing base (84a23e6) to head (ab87dba).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #360   +/-   ##
==========================================
  Coverage      57.70%   57.70%           
  Complexity       617      617           
==========================================
  Files             46       46           
  Lines           3173     3173           
==========================================
  Hits            1831     1831           
  Misses          1342     1342           
Flag Coverage Δ
unit 57.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkotter dkotter changed the title Attempt to fix flaky tests Fix failing and flaky E2E tests Apr 1, 2026
@dkotter dkotter merged commit 249ecb9 into WordPress:develop Apr 1, 2026
17 checks passed
@dkotter dkotter deleted the fix/flaky-image-edit-test branch April 1, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants